You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/01 17:27:47 UTC

[PR] fix(proxy): strip IPv6 brackets when probing proxy topology [rocketmq-dashboard]

yyqdbngt opened a new pull request, #2923:
URL: https://github.com/apache/rocketmq-dashboard/pull/2923

   ## Summary
   
   Proxy addresses are stored bracketed for IPv6 (`[::1]:8081`) — that format is validated on add and shown to users — but `buildTopology()` passed the bracketed host straight to the health probe. `InetSocketAddress` treats a bracketed IPv6 literal as a *hostname*, so the lookup always failed with an unknown-host error and every registered IPv6 proxy was reported as DOWN even while healthy.
   
   The topology build now strips the brackets before probing, so IPv6 proxies get the same TCP treatment as IPv4 and hostname entries.
   
   ## Why
   
   `addProxyAddr` explicitly accepts and validates bracketed IPv6 addresses, but the topology view could never show one as UP — a live IPv6 proxy looked dead in the console.
   
   ## Testing
   
   Extended `ProxyAddressServiceTest`: a new case registers `[::1]:9001` with a capturing probe and asserts the probe receives the bare literal `::1` and the node reports UP.
   
   ```
   mvn -q -Dtest=ProxyAddressServiceTest test
   Tests run: 18, Failures: 0, Errors: 0, Skipped: 0
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(proxy): strip IPv6 brackets when probing proxy topology [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2923: fix(proxy): strip IPv6 brackets when probing proxy topology
URL: https://github.com/apache/rocketmq-dashboard/pull/2923


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(proxy): strip IPv6 brackets when probing proxy topology [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2923:
URL: https://github.com/apache/rocketmq-dashboard/pull/2923#issuecomment-5593757729

   This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org