You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/15 13:12:29 UTC
[GitHub] [beam] MakarkinSAkvelon opened a new pull request, #22724: [Playground] Update build_playground_backend.yml - add "Index creation" in backend pipeline
MakarkinSAkvelon opened a new pull request, #22724:
URL: https://github.com/apache/beam/pull/22724
A step with "index creation" should be added to the "build_playground_backend" pipeline as part of the "ShareAnyCode" feature addition.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #22724: [Playground] Update build_playground_backend.yml - add "Index creation" in backend pipeline
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #22724:
URL: https://github.com/apache/beam/pull/22724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] MakarkinSAkvelon commented on pull request #22724: [Playground] Update build_playground_backend.yml - add "Index creation" in backend pipeline
Posted by GitBox <gi...@apache.org>.
MakarkinSAkvelon commented on PR #22724:
URL: https://github.com/apache/beam/pull/22724#issuecomment-1215297274
resolves #22336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22724: [Playground] Update build_playground_backend.yml - add "Index creation" in backend pipeline
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22724:
URL: https://github.com/apache/beam/pull/22724#issuecomment-1215082190
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22724: [Playground] Update build_playground_backend.yml - add "Index creation" in backend pipeline
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22724:
URL: https://github.com/apache/beam/pull/22724#issuecomment-1230573232
lgtm merging for now but let's follow up on the sticky point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22724: [Playground] Update build_playground_backend.yml - add "Index creation" in backend pipeline
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22724:
URL: https://github.com/apache/beam/pull/22724#issuecomment-1216574453
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on a diff in pull request #22724: [Playground] Update build_playground_backend.yml - add "Index creation" in backend pipeline
Posted by GitBox <gi...@apache.org>.
damondouglas commented on code in PR #22724:
URL: https://github.com/apache/beam/pull/22724#discussion_r949779830
##########
.github/workflows/build_playground_backend.yml:
##########
@@ -85,3 +85,9 @@ jobs:
GOOGLE_APPLICATION_CREDENTIALS: /tmp/gcp_access.json
run: ./gradlew playground:terraform:deployBackend -Pdocker-tag=${{env.DOCKERTAG}} -Pproject_id=${{ secrets.GCP_PLAYGROUND_PROJECT_ID }} -Pproject_environment='beta' -Pdocker-repository-root='${{ secrets.PLAYGROUND_REGISTRY_NAME}}/${{ secrets.GCP_PLAYGROUND_PROJECT_ID }}/playground-repository'
if: startsWith(github.ref, 'refs/tags/')
+ - name: DB Index creation
+ run: |
+ gcloud auth activate-service-account --project=${{ secrets.GCP_PLAYGROUND_PROJECT_ID }} --key-file=/tmp/gcp_access.json
Review Comment:
This is not a blocker on the PR, but I want to ask, there's no way to use service account impersonation instead of activating a service account via a downloaded key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] MakarkinSAkvelon commented on a diff in pull request #22724: [Playground] Update build_playground_backend.yml - add "Index creation" in backend pipeline
Posted by GitBox <gi...@apache.org>.
MakarkinSAkvelon commented on code in PR #22724:
URL: https://github.com/apache/beam/pull/22724#discussion_r955660920
##########
.github/workflows/build_playground_backend.yml:
##########
@@ -85,3 +85,9 @@ jobs:
GOOGLE_APPLICATION_CREDENTIALS: /tmp/gcp_access.json
run: ./gradlew playground:terraform:deployBackend -Pdocker-tag=${{env.DOCKERTAG}} -Pproject_id=${{ secrets.GCP_PLAYGROUND_PROJECT_ID }} -Pproject_environment='beta' -Pdocker-repository-root='${{ secrets.PLAYGROUND_REGISTRY_NAME}}/${{ secrets.GCP_PLAYGROUND_PROJECT_ID }}/playground-repository'
if: startsWith(github.ref, 'refs/tags/')
+ - name: DB Index creation
+ run: |
+ gcloud auth activate-service-account --project=${{ secrets.GCP_PLAYGROUND_PROJECT_ID }} --key-file=/tmp/gcp_access.json
Review Comment:
I got following error even if I try to use "--impersonate-service-account SERVICE_ACCOUNT":
WARNING: This command is using service account impersonation. All API calls will be executed as [ms1-demo-svc@***.iam.gserviceaccount.com].
WARNING: Could not open the configuration file: [/home/runner/.config/gcloud/configurations/config_default].
ERROR: (gcloud.app.deploy) You do not currently have an active account selected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22724: [Playground] Update build_playground_backend.yml - add "Index creation" in backend pipeline
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22724:
URL: https://github.com/apache/beam/pull/22724#issuecomment-1231985918
@MakarkinSAkvelon Looks like GitHub Action "Build Playground Backend App" has been failed since this: https://github.com/apache/beam/runs/8075667475?check_suite_focus=true
The error message is
```
Run gcloud auth activate-service-account --project=*** --key-file=/tmp/gcp_access.json
ERROR: (gcloud.auth.activate-service-account) Unable to read file [/tmp/gcp_access.json]: [Errno 2] No such file or directory: '/tmp/gcp_access.json'
Error: Process completed with exit code 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on pull request #22724: [Playground] Update build_playground_backend.yml - add "Index creation" in backend pipeline
Posted by GitBox <gi...@apache.org>.
olehborysevych commented on PR #22724:
URL: https://github.com/apache/beam/pull/22724#issuecomment-1216561275
R: @damondouglas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on pull request #22724: [Playground] Update build_playground_backend.yml - add "Index creation" in backend pipeline
Posted by GitBox <gi...@apache.org>.
olehborysevych commented on PR #22724:
URL: https://github.com/apache/beam/pull/22724#issuecomment-1215302419
lgtm (internal review)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on pull request #22724: [Playground] Update build_playground_backend.yml - add "Index creation" in backend pipeline
Posted by GitBox <gi...@apache.org>.
olehborysevych commented on PR #22724:
URL: https://github.com/apache/beam/pull/22724#issuecomment-1215047356
lgtm (internal review)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org