You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/07/22 01:17:14 UTC

[GitHub] [hudi] leesf commented on a change in pull request #1851: [HUDI-1113] Add user define metrics reporter

leesf commented on a change in pull request #1851:
URL: https://github.com/apache/hudi/pull/1851#discussion_r458477384



##########
File path: hudi-client/src/main/java/org/apache/hudi/metrics/MetricsReporterFactory.java
##########
@@ -48,6 +51,10 @@ public static MetricsReporter createReporter(HoodieWriteConfig config, MetricReg
       case DATADOG:
         reporter = new DatadogMetricsReporter(config, registry);
         break;
+      case USER_DEFINED:

Review comment:
       we would remove this, please refer to https://github.com/apache/hudi/blob/master/hudi-client/src/main/java/org/apache/hudi/index/HoodieIndex.java#L56




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org