You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/16 03:16:00 UTC

[jira] [Work logged] (BEAM-6063) KafkaIO: add writing support with ProducerRecord

     [ https://issues.apache.org/jira/browse/BEAM-6063?focusedWorklogId=166752&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166752 ]

ASF GitHub Bot logged work on BEAM-6063:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Nov/18 03:15
            Start Date: 16/Nov/18 03:15
    Worklog Time Spent: 10m 
      Work Description: rangadi commented on issue #7052: [BEAM-6063] KafkaIO: add writing support with ProducerRecord
URL: https://github.com/apache/beam/pull/7052#issuecomment-439268422
 
 
   LGTM overall.
   I left a few comments. Most important one is about leaving a TODO about using API similar to PubsubIO. I think we should do that in 3.0 (next major version). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 166752)
    Time Spent: 0.5h  (was: 20m)

> KafkaIO: add writing support with ProducerRecord
> ------------------------------------------------
>
>                 Key: BEAM-6063
>                 URL: https://issues.apache.org/jira/browse/BEAM-6063
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-kafka
>            Reporter: Alexey Romanenko
>            Assignee: Alexey Romanenko
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently, the default input collection for {{KafkaIO.Write}} is {{PCollection<KV<K,V>>}}. To support writing of Kafka headers or different output Kafka topics, we need to change type of input collection to {{PCollection<ProducerRecord<K,V>>}}. Also, it will make sense to use {{ProducerRecord<K,V>}} instead of {{KV<K,V>}} internally in {{KafkaIO}} to keep all meta information.
> In the same time, we need to keep compatibility for old interface based on {{KV<K,V>}} but make it deprecated and totally move to {{ProducerRecord<K,V>}} later.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)