You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinson Lee <vl...@freedesktop.org> on 2013/08/10 20:29:27 UTC
Review Request 13473: Update glog to 0.3.3.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13473/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Eric Biederman, Ian Downes, David Mackey, and Vinod Kone.
Repository: mesos-git
Description
-------
Update glog to 0.3.3.
Fix clang build error.
src/logging.cc:1246:8: error: cannot initialize a variable of type 'void (*)() __attribute__((noreturn))' with an rvalue of type 'void (*)()'
void (*g_logging_fail_func)() __attribute__((noreturn)) = &logging_fail;
^ ~~~~~~~~~~~~~
Signed-off-by: Vinson Lee <vl...@twitter.com>
Diffs
-----
3rdparty/libprocess/3rdparty/glog-0.3.1.tar.gz 19b4b9434e0910ef435d8a08a5fe87c8c847a69b
3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/versions.am 0d05698
Diff: https://reviews.apache.org/r/13473/diff/
Testing
-------
make
Thanks,
Vinson Lee
Re: Review Request 13473: Update glog to 0.3.3.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13473/#review25012
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Aug. 10, 2013, 6:29 p.m., Vinson Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13473/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2013, 6:29 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Eric Biederman, Ian Downes, David Mackey, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Update glog to 0.3.3.
>
> Fix clang build error.
>
> src/logging.cc:1246:8: error: cannot initialize a variable of type 'void (*)() __attribute__((noreturn))' with an rvalue of type 'void (*)()'
> void (*g_logging_fail_func)() __attribute__((noreturn)) = &logging_fail;
> ^ ~~~~~~~~~~~~~
>
> Signed-off-by: Vinson Lee <vl...@twitter.com>
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/glog-0.3.1.tar.gz 19b4b9434e0910ef435d8a08a5fe87c8c847a69b
> 3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz PRE-CREATION
> 3rdparty/libprocess/3rdparty/versions.am 0d05698
>
> Diff: https://reviews.apache.org/r/13473/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Vinson Lee
>
>
Re: Review Request 13473: Update glog to 0.3.3.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13473/#review25028
-----------------------------------------------------------
Thanks Vinson! I've committed this one, can you mark it as submitted?
FYI I also ended up patching src/python/setup.py.in which need a change along with this upgrade.
- Ben Mahler
On Aug. 10, 2013, 6:29 p.m., Vinson Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13473/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2013, 6:29 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Eric Biederman, Ian Downes, David Mackey, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Update glog to 0.3.3.
>
> Fix clang build error.
>
> src/logging.cc:1246:8: error: cannot initialize a variable of type 'void (*)() __attribute__((noreturn))' with an rvalue of type 'void (*)()'
> void (*g_logging_fail_func)() __attribute__((noreturn)) = &logging_fail;
> ^ ~~~~~~~~~~~~~
>
> Signed-off-by: Vinson Lee <vl...@twitter.com>
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/glog-0.3.1.tar.gz 19b4b9434e0910ef435d8a08a5fe87c8c847a69b
> 3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz PRE-CREATION
> 3rdparty/libprocess/3rdparty/versions.am 0d05698
>
> Diff: https://reviews.apache.org/r/13473/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Vinson Lee
>
>