[GitHub] [pulsar] zymap commented on a change in pull request #4390: Update argument description of web service

[GitBox <gi...@apache.org>]

zymap commented on a change in pull request #4390: Update argument description of web service
URL: https://github.com/apache/pulsar/pull/4390#discussion_r289673568
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java
 ##########
 @@ -113,10 +121,12 @@
     @POST
     @Path("/configuration/{configName}/{configValue}")
     @ApiOperation(value = "Update dynamic serviceconfiguration into zk only. This operation requires Pulsar super-user privileges.")
-    @ApiResponses(value = { @ApiResponse(code = 204, message = "Service configuration updated successfully"),
-            @ApiResponse(code = 403, message = "You don't have admin permission to update service-configuration"),
-            @ApiResponse(code = 404, message = "Configuration not found"),
-            @ApiResponse(code = 412, message = "Configuration can't be updated dynamically") })
+    @ApiResponses(value = {
+        @ApiResponse(code = 204, message = "Service configuration updated successfully"),
+        @ApiResponse(code = 403, message = "You don't have admin permission to update service-configuration"),
+        @ApiResponse(code = 404, message = "Configuration not found"),
+        @ApiResponse(code = 412, message = "Invalid dynamic-config value"),
+        @ApiResponse(code = 500, message = "Service internal error")})
 
 Review comment:
   yeah, updated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services