[GitHub] [shardingsphere] tristaZero commented on a change in pull request #11091: extract SchemaAvailable interface & add validate for SelectStatement

[GitBox <gi...@apache.org>]

tristaZero commented on a change in pull request #11091:
URL: https://github.com/apache/shardingsphere/pull/11091#discussion_r662286813



##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSpherePreparedStatement.java
##########
@@ -367,7 +367,8 @@ private ExecutionContext createExecutionContext() {
     private LogicSQL createLogicSQL() {
         List<Object> parameters = new ArrayList<>(getParameters());
         ShardingSphereSchema schema = metaDataContexts.getDefaultMetaData().getSchema();
-        SQLStatementContext<?> sqlStatementContext = SQLStatementContextFactory.newInstance(schema, parameters, sqlStatement);
+        SQLStatementContext<?> sqlStatementContext = SQLStatementContextFactory.newInstance(parameters, sqlStatement);
+        sqlStatementContext.initSchemaBasedContext(schema);

Review comment:
       Is it necessary to use `initSchemaBasedContext` instead of `SQLStatementContextFactory.newInstance`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org