[GitHub] [superset] betodealmeida commented on a change in pull request #17511: fix: Dashboard access when DASHBOARD_RBAC is disabled

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #17511:
URL: https://github.com/apache/superset/pull/17511#discussion_r754530288



##########
File path: tests/integration_tests/dashboards/api_tests.py
##########
@@ -395,7 +395,7 @@ def test_get_dashboard_no_data_access(self):
         self.login(username="gamma")
         uri = f"api/v1/dashboard/{dashboard.id}"
         rv = self.client.get(uri)
-        self.assertEqual(rv.status_code, 200)
+        self.assertEqual(rv.status_code, 403)

Review comment:
       Nit (I know this was already using `self.assertEqual`, but might as well update it):
   
   ```suggestion
           assert rv.status_code == 403
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org