You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2016/09/09 06:45:08 UTC
[GitHub] zeppelin pull request #1419: ZEPPELIN-1420. java.util.ConcurrentModification...
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/1419
ZEPPELIN-1420. java.util.ConcurrentModificationException caused by calling remove inside foreach loop
### What is this PR for?
We should use Iterator to iterate the list when we want to remove items in the middle of iteration, Otherwise will get the ConcurrentModificationException
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1420
### How should this be tested?
No test added
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1420
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1419.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1419
----
commit 5431de5b78e2fe82a578cc21b1777f7fa5ee9ef8
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-09-09T06:41:26Z
ZEPPELIN-1420. java.util.ConcurrentModificationException caused by calling remove inside foreach loop
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1419: ZEPPELIN-1420. java.util.ConcurrentModificationExcepti...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1419
Shall we merge this guy now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1419: ZEPPELIN-1420. java.util.ConcurrentModificationExcepti...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1419
tested locally, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1419: ZEPPELIN-1420. java.util.ConcurrentModificationExcepti...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1419
LGTM and merge if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1419: ZEPPELIN-1420. java.util.ConcurrentModification...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1419
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1419: ZEPPELIN-1420. java.util.ConcurrentModificationExcepti...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1419
Merging to master, if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] zeppelin pull request #1419: ZEPPELIN-1420. java.util.ConcurrentModification...
Posted by Andrea Santurbano <sa...@gmail.com>.
Mm
Il ven 9 set 2016 08:45 zjffdu <gi...@git.apache.org> ha scritto:
> GitHub user zjffdu opened a pull request:
>
> https://github.com/apache/zeppelin/pull/1419
>
> ZEPPELIN-1420. java.util.ConcurrentModificationException caused by
> calling remove inside foreach loop
>
> ### What is this PR for?
> We should use Iterator to iterate the list when we want to remove
> items in the middle of iteration, Otherwise will get the
> ConcurrentModificationException
>
>
> ### What type of PR is it?
> [Bug Fix]
>
> ### Todos
> * [ ] - Task
>
> ### What is the Jira issue?
> * https://issues.apache.org/jira/browse/ZEPPELIN-1420
>
> ### How should this be tested?
> No test added
>
> ### Questions:
> * Does the licenses files need update? No
> * Is there breaking changes for older versions? No
> * Does this needs documentation? No
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1420
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/zeppelin/pull/1419.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #1419
>
> ----
> commit 5431de5b78e2fe82a578cc21b1777f7fa5ee9ef8
> Author: Jeff Zhang <zj...@apache.org>
> Date: 2016-09-09T06:41:26Z
>
> ZEPPELIN-1420. java.util.ConcurrentModificationException caused by
> calling remove inside foreach loop
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>