You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Ivan (JIRA)" <ji...@apache.org> on 2011/01/07 03:59:45 UTC

[jira] Created: (AMQ-3121) Avoid connection creation while creating XAResource if the connection factory is not an xa connection factory

Avoid connection creation while creating XAResource if the connection factory is not an xa connection factory
-------------------------------------------------------------------------------------------------------------

                 Key: AMQ-3121
                 URL: https://issues.apache.org/jira/browse/AMQ-3121
             Project: ActiveMQ
          Issue Type: Improvement
          Components: JCA Container
    Affects Versions: 5.4.2
            Reporter: Ivan


Avoid connection creation while creating XAResource if the connection factory is not xa connection factory, also, if it is xa connection, I think that the connection should not be closed as the new created xa resource holds reference to connection.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] [Updated] (AMQ-3121) Avoid connection creation while creating XAResource if the connection factory is not an xa connection factory

Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vamsavardhana Reddy updated AMQ-3121:
-------------------------------------

    Attachment: AMQ-3121-v412-backport.patch

AMQ-3121-v412-backport.patch:
I have back ported the fix to ActiveMQ 4.1.2 for use with Geronimo 2.1.7 in my test environment. I am also caching one connection which will be closed when the resource adapter is stopped.  Strangely, I do not see the code execution ever going inside the block where connection is created!!! Anything I am missing??

> Avoid connection creation while creating XAResource if the connection factory is not an xa connection factory
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-3121
>                 URL: https://issues.apache.org/jira/browse/AMQ-3121
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: JCA Container
>    Affects Versions: 5.4.2
>            Reporter: Ivan
>         Attachments: AMQ-3121-v412-backport.patch, ActiveMQ-3121.patch
>
>
> Avoid connection creation while creating XAResource if the connection factory is not xa connection factory, also, if it is xa connection, I think that the connection should not be closed as the new created xa resource holds reference to connection.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (AMQ-3121) Avoid connection creation while creating XAResource if the connection factory is not an xa connection factory

Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vamsavardhana Reddy updated AMQ-3121:
-------------------------------------

    Attachment: AMQ-3121-v412.patch

AMQ-3121-v412.patch:
Same as AMQ-3121-v412-backport.patch, except that it is created against branches/activemq-4.1 at latest revision 1100085 as on 2011-05-06.

> Avoid connection creation while creating XAResource if the connection factory is not an xa connection factory
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-3121
>                 URL: https://issues.apache.org/jira/browse/AMQ-3121
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: JCA Container
>    Affects Versions: 5.4.2
>            Reporter: Ivan
>         Attachments: AMQ-3121-v412-backport.patch, AMQ-3121-v412.patch, ActiveMQ-3121.patch
>
>
> Avoid connection creation while creating XAResource if the connection factory is not xa connection factory, also, if it is xa connection, I think that the connection should not be closed as the new created xa resource holds reference to connection.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AMQ-3121) Avoid connection creation while creating XAResource if the connection factory is not an xa connection factory

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQ-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017604#comment-13017604 ] 

David Jencks commented on AMQ-3121:
-----------------------------------

Ivan's patch at least makes recovery for inbound messaging plausible, but as Gary points out leaves a connection leak.  I don't recall how amq gets a connection for delivering inbound messages.  If this connection is cached, can we arrange to use the connection obtained for transaction recovery for inbound message delivery?

> Avoid connection creation while creating XAResource if the connection factory is not an xa connection factory
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-3121
>                 URL: https://issues.apache.org/jira/browse/AMQ-3121
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: JCA Container
>    Affects Versions: 5.4.2
>            Reporter: Ivan
>         Attachments: ActiveMQ-3121.patch
>
>
> Avoid connection creation while creating XAResource if the connection factory is not xa connection factory, also, if it is xa connection, I think that the connection should not be closed as the new created xa resource holds reference to connection.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (AMQ-3121) Avoid connection creation while creating XAResource if the connection factory is not an xa connection factory

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQ-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980120#action_12980120 ] 

Gary Tully commented on AMQ-3121:
---------------------------------

hmm, not doing the close on the connection used to create the XA Resource will leave a connection leak. There is no way to close an XAResource, so I think it is up to the resource adapter to manage the connection and close it when the resource adapter is shutdown.

> Avoid connection creation while creating XAResource if the connection factory is not an xa connection factory
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-3121
>                 URL: https://issues.apache.org/jira/browse/AMQ-3121
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: JCA Container
>    Affects Versions: 5.4.2
>            Reporter: Ivan
>         Attachments: ActiveMQ-3121.patch
>
>
> Avoid connection creation while creating XAResource if the connection factory is not xa connection factory, also, if it is xa connection, I think that the connection should not be closed as the new created xa resource holds reference to connection.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (AMQ-3121) Avoid connection creation while creating XAResource if the connection factory is not an xa connection factory

Posted by "Ivan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan updated AMQ-3121:
----------------------

    Attachment: ActiveMQ-3121.patch

> Avoid connection creation while creating XAResource if the connection factory is not an xa connection factory
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-3121
>                 URL: https://issues.apache.org/jira/browse/AMQ-3121
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: JCA Container
>    Affects Versions: 5.4.2
>            Reporter: Ivan
>         Attachments: ActiveMQ-3121.patch
>
>
> Avoid connection creation while creating XAResource if the connection factory is not xa connection factory, also, if it is xa connection, I think that the connection should not be closed as the new created xa resource holds reference to connection.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.