You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by jg...@apache.org on 2017/06/29 16:51:15 UTC

kafka git commit: MINOR: Improve TransactionIndex.sanityCheck() message

Repository: kafka
Updated Branches:
  refs/heads/trunk dc95456f1 -> 27fdd46dc


MINOR: Improve TransactionIndex.sanityCheck() message

Author: Ismael Juma <is...@juma.me.uk>

Reviewers: Jason Gustafson <ja...@confluent.io>

Closes #3446 from ijuma/improve-transaction-index-exception-sanity-check


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/27fdd46d
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/27fdd46d
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/27fdd46d

Branch: refs/heads/trunk
Commit: 27fdd46dcd303566a35d4824c571cf988912575e
Parents: dc95456
Author: Ismael Juma <is...@juma.me.uk>
Authored: Thu Jun 29 09:51:04 2017 -0700
Committer: Jason Gustafson <ja...@confluent.io>
Committed: Thu Jun 29 09:51:04 2017 -0700

----------------------------------------------------------------------
 core/src/main/scala/kafka/log/TransactionIndex.scala | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/27fdd46d/core/src/main/scala/kafka/log/TransactionIndex.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/log/TransactionIndex.scala b/core/src/main/scala/kafka/log/TransactionIndex.scala
index f8a3879..9afe009 100644
--- a/core/src/main/scala/kafka/log/TransactionIndex.scala
+++ b/core/src/main/scala/kafka/log/TransactionIndex.scala
@@ -174,7 +174,8 @@ class TransactionIndex(val startOffset: Long, @volatile var file: File) extends
   def sanityCheck(): Unit = {
     val buffer = ByteBuffer.allocate(AbortedTxn.TotalSize)
     for ((abortedTxn, _) <- iterator(() => buffer)) {
-      require(abortedTxn.lastOffset >= startOffset)
+      require(abortedTxn.lastOffset >= startOffset, s"Last offset of aborted transaction $abortedTxn is less than " +
+        s"start offset $startOffset")
     }
   }