You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by milamberspace <gi...@git.apache.org> on 2015/11/10 01:18:28 UTC
[GitHub] cloudstack pull request: Fix the new line bug (invalid char on UI)...
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/1053
Fix the new line bug (invalid char on UI), add some Spanish translati…
…on from Transifex
Some strings with invalid encoding has been fixed too (Thanks Nicolas Vazquez)
Related to CLOUDSTACK-9043
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/milamberspace/cloudstack DoubleCheckL10N-Fix-SpanishNewLine
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1053.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1053
----
commit 875e12213ea46ef9330aa65e12ba5d251ade70f0
Author: Milamber <mi...@apache.org>
Date: 2015-11-10T00:13:29Z
Fix the new line bug (invalid char on UI), add some Spanish translation from Transifex
Related to CLOUDSTACK-9043
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix the new line bug (invalid char on UI)...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1053
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix the new line bug (invalid char on UI)...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1053#issuecomment-155410386
going to trust the translator: lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix the new line bug (invalid char on UI)...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1053#issuecomment-155398572
verified in spanish and english that that UI loads fine. did not see any js errors in spanish.
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---