You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Ruben Quesada Lopez (Jira)" <ji...@apache.org> on 2019/09/01 08:27:00 UTC

[jira] [Resolved] (CALCITE-3309) Refactor generatePredicate method from EnumerableNestedLoopJoin/EnumerableHashJoin/EnumerableBatchNestedLoopJoin into a single location

     [ https://issues.apache.org/jira/browse/CALCITE-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruben Quesada Lopez resolved CALCITE-3309.
------------------------------------------
    Resolution: Fixed

Fixed via https://github.com/apache/calcite/commit/55cc3abfbcb906935a703a5cf77b1b0359fca734

> Refactor generatePredicate method from EnumerableNestedLoopJoin/EnumerableHashJoin/EnumerableBatchNestedLoopJoin into a single location
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-3309
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3309
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Ruben Quesada Lopez
>            Assignee: Ruben Quesada Lopez
>            Priority: Trivial
>              Labels: pull-request-available
>             Fix For: 1.21.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> The method {{EnumerableNestedLoopJoin#predicate}} (that generates a Predicate Expression based on a RexNode condition) has been copied pasted as {{EnumerableBatchNestedLoopJoin#generatePredicate}} due to CALCITE-2979, and {{EnumerableHashJoin#generatePredicate}} due to CALCITE-2973.
> The goal of this ticket is to refactor that method into a single location (e.g. EnumUtils) where it can be accessible by all 3 Enumerable Joins.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)