[GitHub] spark pull request #17373: [SPARK-12664][ML] Expose probability in mlp model

[jkbradley <gi...@git.apache.org>]

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17373#discussion_r133075752
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifierSuite.scala ---
    @@ -82,6 +83,49 @@ class MultilayerPerceptronClassifierSuite
         }
       }
     
    +  test("strong dataset test") {
    +    val layers = Array[Int](4, 5, 5, 2)
    +
    +    val strongDataset = Seq(
    +      (Vectors.dense(1, 2, 3, 4), 0d, Vectors.dense(1d, 0d)),
    +      (Vectors.dense(4, 3, 2, 1), 1d, Vectors.dense(0d, 1d)),
    +      (Vectors.dense(1, 1, 1, 1), 0d, Vectors.dense(.5, .5)),
    +      (Vectors.dense(1, 1, 1, 1), 1d, Vectors.dense(.5, .5))
    +    ).toDF("features", "label", "expectedProbability")
    +    val trainer = new MultilayerPerceptronClassifier()
    +      .setLayers(layers)
    +      .setBlockSize(1)
    +      .setSeed(123L)
    +      .setMaxIter(100)
    +      .setSolver("l-bfgs")
    +    val model = trainer.fit(strongDataset)
    +    val result = model.transform(strongDataset)
    +    model.setProbabilityCol("probability")
    +    MLTestingUtils.checkCopyAndUids(trainer, model)
    --- End diff --
    
    checkCopyAndUids is a generic test which should only be run in a single test; it does not need to be run in each test.  Please remove it from here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org