[GitHub] [metamodel] kaspersorensen commented on a change in pull request #221: Access CSVParser in a synchronized manner

[GitBox <gi...@apache.org>]

kaspersorensen commented on a change in pull request #221: Access CSVParser in a synchronized manner
URL: https://github.com/apache/metamodel/pull/221#discussion_r293771783
 
 

 ##########
 File path: csv/src/main/java/org/apache/metamodel/csv/CsvConfiguration.java
 ##########
 @@ -195,4 +199,17 @@ public String toString() {
                 + ", separatorChar=" + separatorChar + ", quoteChar=" + quoteChar + ", escapeChar=" + escapeChar
                 + ", failOnInconsistentRowLength=" + failOnInconsistentRowLength + "]";
     }
+    
+    public ICSVParser createParser() {
 
 Review comment:
   Hmm I'd ideally like this somewhere else than in CsvConfiguration. I consider CsvConfiguration part of MetaModel's public API and so it would be bad to also expose OpenCSV classes. Just in case we ever need to switch to another CSV parser library.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services