You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "Jimexist (via GitHub)" <gi...@apache.org> on 2023/01/29 15:14:04 UTC

[GitHub] [thrift] Jimexist commented on a diff in pull request #2746: [Waiting for Jira Access] Migration to JakartaEE and Apache HttpComponents 5

Jimexist commented on code in PR #2746:
URL: https://github.com/apache/thrift/pull/2746#discussion_r1089987424


##########
compiler/cpp/src/thrift/generate/t_java_generator.cc:
##########
@@ -5807,7 +5811,12 @@ void t_java_generator::generate_java_scheme_lookup(ostream& out) {
 void t_java_generator::generate_javax_generated_annotation(ostream& out) {
   time_t seconds = time(nullptr);
   struct tm* now = localtime(&seconds);
-  indent(out) << "@javax.annotation.Generated(value = \"" << autogen_summary() << "\"";
+  if (!javax_annotations_) {
+    indent(out) << "@jakarta.annotation.Generated(value = \"" << autogen_summary() << "\"";
+  } else {
+    indent(out) << "@javax.annotation.Generated(value = \"" << autogen_summary() << "\"";
+  }
+

Review Comment:
   can you swap two legs of the if statement?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org