You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ChenSammi (via GitHub)" <gi...@apache.org> on 2025/03/06 13:37:57 UTC
Re: [PR] HDDS-12462. Use exclude rules for defining shaded filesystem jar contents [ozone]
ChenSammi commented on code in PR #8008:
URL: https://github.com/apache/ozone/pull/8008#discussion_r1983370612
##########
hadoop-ozone/ozonefs-shaded/pom.xml:
##########
@@ -120,38 +129,47 @@
<relocation>
<pattern>org</pattern>
<shadedPattern>${shaded.prefix}.org</shadedPattern>
- <includes>
- <include>org.yaml.**.*</include>
- <include>org.sqlite.**.*</include>
- <include>org.tukaani.**.*</include>
- <include>org.bouncycastle.**.*</include>
- <include>org.rocksdb.**.*</include>
- <include>org.apache.commons.cli.**.*</include>
- <include>org.apache.commons.compress.**.*</include>
- <include>org.apache.commons.codec.**.*</include>
- <include>org.apache.commons.beanutils.**.*</include>
- <include>org.apache.commons.collections.**.*</include>
- <include>org.apache.commons.digester.**.*</include>
- <include>org.apache.commons.io.**.*</include>
- <include>org.apache.commons.logging.**.*</include>
- <include>org.apache.commons.validator.**.*</include>
- <include>org.apache.commons.lang3.**.*</include>
- <include>org.sqlite.**.*</include>
- <include>org.apache.thrift.**.*</include>
- </includes>
+ <excludes>
+ <exclude>org.apache.commons.logging.**</exclude>
Review Comment:
```
org.apache.commons.logging.**
org.bouncycastle.**
```
These two are included to shade currently, but excluded in the new change. Is there any impact if not shaded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org