[GitHub] [kylin] zhangayqian commented on a change in pull request #1631: KYLIN-4941 support encoding raw data to base cuboid column-by-column

[GitBox <gi...@apache.org>]

zhangayqian commented on a change in pull request #1631:
URL: https://github.com/apache/kylin/pull/1631#discussion_r633984742



##########
File path: engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkCubingByLayer.java
##########
@@ -330,15 +409,12 @@ public EncodeBaseCuboid(String cubeName, String segmentId, String metaurl, Seria
                             long baseCuboidId = Cuboid.getBaseCuboidId(cubeDesc);
                             Cuboid baseCuboid = Cuboid.findForMandatory(cubeDesc, baseCuboidId);
                             String splitKey = String.valueOf(TaskContext.getPartitionId());
-                            try {

Review comment:
       Why remove this try catch?

##########
File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -2709,7 +2709,11 @@ public int getDistCPMaxMapNum(){
         return Integer.valueOf(getOptional("kylin.storage.distcp-max-map-num", "50"));
     }
 
-    public String getKylinDictCacheStrength(){
+    public String getKylinDictCacheStrength() {
         return getOptional("kylin.dict.cache.strength", "soft");
-    };
+    }
+
+    public boolean encodeBaseCuboidColumnByColumn() {
+        return Boolean.valueOf(getOptional("kylin.job.encode.base.cuboid.column-by-column", "false"));

Review comment:
       Is this configuration item more suitable for cube level configuration?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org