[GitHub] [beam] damondouglas commented on a change in pull request #12024: [BEAM-9679] Add Side Input to Core Transform Go SDK katas

[GitBox <gi...@apache.org>]

damondouglas commented on a change in pull request #12024:
URL: https://github.com/apache/beam/pull/12024#discussion_r441763172



##########
File path: learning/katas/go/Core Transforms/Side Input/Side Input/pkg/task/task.go
##########
@@ -0,0 +1,45 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package task
+
+import (
+	"github.com/apache/beam/sdks/go/pkg/beam"
+)
+
+type Person struct {
+	Name, City, Country string
+}
+
+func ApplyTransform(s beam.Scope, personsKV beam.PCollection, citiesToCountries beam.PCollection) beam.PCollection {
+	citiesToCountriesView := beam.SideInput{
+		Input: citiesToCountries,
+	}
+	return beam.ParDo(s, joinFn, personsKV, citiesToCountriesView)
+}
+
+func joinFn(person Person, citiesToCountriesIter func(*string, *string) bool, emit func(Person)) {
+	var city, country string
+	for citiesToCountriesIter(&city, &country) {

Review comment:
       Is the state of Side Input iterating of KV in the Go SDK currently preventing this kata from being helpful?  Should we hold off on a Side Input lesson at this time or change the example to a singleton Side Input like what is done in the documentation?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org