You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/17 10:06:10 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #16109: [improve][pom] Remove redundant pulsar-zookeeper-utils module
tisonkun opened a new pull request, #16109:
URL: https://github.com/apache/pulsar/pull/16109
!!YOU DON'T NEED TO REVIEW THIS PATCH UNTIL CI PASSED!!
Fixes #TBD
### Motivation
As PIP-45 moved forward, pulsar-zookeeper-utils is redundant to be a dedicated module. Move the remaining classes to pulsar-broker.
### Modifications
Remove pulsar-zookeeper-utils module and move remaining utils to pulsar-broker module.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): **yes**
This change will remove the pulsar-zookeeper-utils module. Since we release pulsar modules simultaneously, I suggest it won't be a big deal.
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj merged pull request #16109: [improve][pom] Remove redundant pulsar-zookeeper-utils module
Posted by GitBox <gi...@apache.org>.
Shoothzj merged PR #16109:
URL: https://github.com/apache/pulsar/pull/16109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16109: [improve][pom] Remove redundant pulsar-zookeeper-utils module
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16109:
URL: https://github.com/apache/pulsar/pull/16109#issuecomment-1161302894
Integrated with #16110 & #16148 .
cc @eolivelli @codelipenghui @merlimat would you please give a review to this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16109: [improve][pom] Remove redundant pulsar-zookeeper-utils module
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16109:
URL: https://github.com/apache/pulsar/pull/16109#issuecomment-1159670746
cc @eolivelli @codelipenghui @merlimat
This can be considered as a follow up to PIP-45. Since it touches OWASP files, it reveals several vulnerability and thus I create #16110 for resolving them separately. However, for testing this patch as a whole, I include them in this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org