You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/25 17:33:27 UTC

[GitHub] [pulsar-client-go] crossoverJie opened a new pull request #753: [Issue 664] fix ReconsumeLater panic

crossoverJie opened a new pull request #753:
URL: https://github.com/apache/pulsar-client-go/pull/753


   
   Fixes #664 
   
   ### Motivation
   
   Removing possible panic.
   
   
   ### Modifications
   
   Add nil check and more friendly tips.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] shileiyu commented on pull request #753: [Issue 664] fix ReconsumeLater panic

Posted by GitBox <gi...@apache.org>.
shileiyu commented on pull request #753:
URL: https://github.com/apache/pulsar-client-go/pull/753#issuecomment-1081383476


   Calling ReconsumeLater without a DLQ policy doesn't make sense in most cases.  that sounds some messages could be stuck in an infinite loop forever.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] crossoverJie commented on pull request #753: [Issue 664] fix ReconsumeLater panic

Posted by GitBox <gi...@apache.org>.
crossoverJie commented on pull request #753:
URL: https://github.com/apache/pulsar-client-go/pull/753#issuecomment-1081471072


   @shileiyu Yes, I agree. 
   
   However, there may be careless developers like me who cause the program to run with panic which can even affect the business, this may cut some losses.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] crossoverJie commented on pull request #753: [Issue 664] fix ReconsumeLater panic

Posted by GitBox <gi...@apache.org>.
crossoverJie commented on pull request #753:
URL: https://github.com/apache/pulsar-client-go/pull/753#issuecomment-1080412996


   
   @Shoothzj would you mind enabling the workflows and reviewing them?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] shileiyu commented on pull request #753: [Issue 664] fix ReconsumeLater panic

Posted by GitBox <gi...@apache.org>.
shileiyu commented on pull request #753:
URL: https://github.com/apache/pulsar-client-go/pull/753#issuecomment-1082698680


   I’m thinking how could we have a better interface to help developers actively avoiding the pitfall.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] shileiyu commented on pull request #753: [Issue 664] fix ReconsumeLater panic

Posted by GitBox <gi...@apache.org>.
shileiyu commented on pull request #753:
URL: https://github.com/apache/pulsar-client-go/pull/753#issuecomment-1085614245


   @crossoverJie do you think having a default DLQ policy would be a better solution to this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org