You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/25 08:43:13 UTC
[GitHub] [apisix-go-plugin-runner] Chever-John opened a new pull request, #82: feat: remove unused HTTPS port
Chever-John opened a new pull request, #82:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/82
This PR aims to solve the problem submitted by #81
1. Let APISIX manage the go-runner in the e2e test runtime, just like the production environment;
2. Remove unused HTTPS port.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Chever-John commented on pull request #82: feat: improve e2e test environment
Posted by GitBox <gi...@apache.org>.
Chever-John commented on PR #82:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/82#issuecomment-1109372256
> Please make the CI pass, thanks!
I am trying~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] soulbird commented on pull request #82: feat: improve e2e test environment
Posted by GitBox <gi...@apache.org>.
soulbird commented on PR #82:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/82#issuecomment-1345730134
> @soulbird I think this PR will not make sense now. It had been a long time. I will close this PR.
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] soulbird commented on pull request #82: feat: improve e2e test environment
Posted by GitBox <gi...@apache.org>.
soulbird commented on PR #82:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/82#issuecomment-1343903648
@Chever-John Do you still have time to complete this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #82: feat: remove unused HTTPS port
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #82:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/82#issuecomment-1108308645
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/82?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#82](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/82?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4486aa5) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/160e058a95538278d22dc73afa18766a21d12199?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (160e058) will **decrease** coverage by `1.74%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4486aa5 differs from pull request most recent head 7357c87. Consider uploading reports for the commit 7357c87 to get more accurate results
```diff
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
- Coverage 81.23% 79.49% -1.75%
==========================================
Files 11 11
Lines 746 746
==========================================
- Hits 606 593 -13
- Misses 102 114 +12
- Partials 38 39 +1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/82/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `56.91% <0.00%> (-10.57%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/82?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/82?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [160e058...7357c87](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/82?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on pull request #82: feat: improve e2e test environment
Posted by GitBox <gi...@apache.org>.
spacewander commented on PR #82:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/82#issuecomment-1109371423
Please make the CI pass, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Chever-John commented on pull request #82: feat: improve e2e test environment
Posted by GitBox <gi...@apache.org>.
Chever-John commented on PR #82:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/82#issuecomment-1344010258
@soulbird
I think this PR will not make sense now.
It had been a long time.
I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] soulbird closed pull request #82: feat: improve e2e test environment
Posted by GitBox <gi...@apache.org>.
soulbird closed pull request #82: feat: improve e2e test environment
URL: https://github.com/apache/apisix-go-plugin-runner/pull/82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org