[GitHub] [dubbo-go] PhilYue commented on a change in pull request #1568: Fix: Make the Consumer config property `Check ` available

[GitBox <gi...@apache.org>]

PhilYue commented on a change in pull request #1568:
URL: https://github.com/apache/dubbo-go/pull/1568#discussion_r744256090



##########
File path: config/reference_config.go
##########
@@ -46,7 +46,7 @@ type ReferenceConfig struct {
 	pxy            *proxy.Proxy
 	id             string
 	InterfaceName  string            `required:"true"  yaml:"interface"  json:"interface,omitempty" property:"interface"`
-	Check          *bool             `default:"true" yaml:"check"  json:"check,omitempty" property:"check"`
+	Check          *bool             `yaml:"check"  json:"check,omitempty" property:"check"`

Review comment:
       为了让 Reference Config 的 check 延用 Consumer Config 的 check 配置，
   如果 reference 的 check 有默认值，就没法判断是用户自己配置的还是默认的




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org