You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by GitBox <gi...@apache.org> on 2023/01/17 22:57:08 UTC
[GitHub] [syncope] hboutemy opened a new pull request, #402: SYNCOPE-1723 remove non-reproducible entries from git.properties
hboutemy opened a new pull request, #402:
URL: https://github.com/apache/syncope/pull/402
see https://issues.apache.org/jira/browse/SYNCOPE-1723
this PR fixes one source of non-reproducible bits
for full path in properties, it would be easy to change value in pom.xml https://github.com/apache/syncope/blob/master/pom.xml#L513 to drop the absolute path, but I don't know if this will break for the builder: what i doubt is that people consuming the resulting artifact can use the value, because the path does not point to anything useful beyond the builder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso commented on pull request #402: SYNCOPE-1723 remove non-reproducible entries from git.properties
Posted by GitBox <gi...@apache.org>.
ilgrosso commented on PR #402:
URL: https://github.com/apache/syncope/pull/402#issuecomment-1386596889
Thank for this PR @hboutemy
I see no issues with the proposed change in this PR, e.g. excluding some GIT properties.
Abouth full-path filtered properties, we haven't been able so far to find viable alternatives without breaking the build process.
Please consider that (a) this hasn't been an issue so far and (b) that [all the provided ways to use Syncope artifacts](https://syncope.apache.org/docs/3.0/getting-started.html#obtain-apache-syncope) are using different filtering for such properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] hboutemy commented on pull request #402: SYNCOPE-1723 remove non-reproducible entries from git.properties
Posted by GitBox <gi...@apache.org>.
hboutemy commented on PR #402:
URL: https://github.com/apache/syncope/pull/402#issuecomment-1396554161
@ilgrosso ok, this filtered properties issue is harder: let's see later
I added 2 other fixes
with the 3 fixes in place, the 7 non-reproducible artifact from releases 3.0.0 and 3.0.1 will drop to only 3 = these filtered properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso merged pull request #402: SYNCOPE-1723 remove non-reproducible entries from git.properties
Posted by GitBox <gi...@apache.org>.
ilgrosso merged PR #402:
URL: https://github.com/apache/syncope/pull/402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso commented on pull request #402: SYNCOPE-1723 remove non-reproducible entries from git.properties
Posted by GitBox <gi...@apache.org>.
ilgrosso commented on PR #402:
URL: https://github.com/apache/syncope/pull/402#issuecomment-1397042366
@hboutemy I have verified that your changes to archetype are not affecting any feature so I'll go ahead and merge this PR to `master` then cherry-pick to `3_0_X` (which is the actual branch from which 3.0.x releases are cut).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org