[GitHub] [trafficserver] maskit opened a new pull request #7384: Remove a special treatment for SSLNetVC in migrateToCurrentThread()

[GitBox <gi...@apache.org>]

maskit opened a new pull request #7384:
URL: https://github.com/apache/trafficserver/pull/7384


   `UnixNetVC::migrateToCurrentThread` has code related to SSL and also duplicate code. This PR moves the SSL related code into SSLNetVC and simplify the duplicated part.
   
   Another small change is moving out calls for `TLSSessionResumptionSupport::bind/unbind` from `SSLNetVCAttach/Detach`. They were integrated on #7278, but I don't think it's a right direction. The calls were intentionally separated from `SSLNetVCAttach/Detach` because I'm trying to delete `SSLNetVCAttach/Detach` which is not applicable forQUICNetVC. I'm going to add these functions below on another PR once this is merged.
   
   ```cpp
   void
   SSLNetVConnection::_bindSSLObject()
   {
     SSLNetVCAttach(this->ssl, this);
     TLSSessionResumptionSupport::bind(this->ssl, this);
   }
   
   void
   SSLNetVConnection::_unbindSSLObject()
   {
     SSLNetVCDetach(this->ssl);
     TLSSessionResumptionSupport::unbind(this->ssl);
   }
   ```
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] maskit merged pull request #7384: Remove a special treatment for SSLNetVC in migrateToCurrentThread()

[GitBox <gi...@apache.org>]

maskit merged pull request #7384:
URL: https://github.com/apache/trafficserver/pull/7384


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] maskit commented on pull request #7384: Remove a special treatment for SSLNetVC in migrateToCurrentThread()

[GitBox <gi...@apache.org>]

maskit commented on pull request #7384:
URL: https://github.com/apache/trafficserver/pull/7384#issuecomment-744335049


   [approve ci autest]
   
   ```
   error: no such commit b5d8e27c03738df863564bd843ada79d68edea82
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org