[GitHub] [accumulo-testing] keith-turner commented on a change in pull request #155: Fix performance test NumberFormatException bug

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r712575317



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -101,7 +101,7 @@ private static void runConditionalMutationsTest(Environment env, String tableNam
     }
 
     reportBuilder.result("avgRate: 1-19",
-        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
+        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 19)),

Review comment:
       > It's weird that we run it 20 times, once before the loop of 19, but not collecting the sum for that first run.
   
   I suspect the first run is done to warm up the JVMs (like make the JIT kick in) and its time is ignored.  Then the times from the next 19 runs are used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org