You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Ben Collins-Sussman <su...@newton.ch.collab.net> on 2001/02/22 22:34:38 UTC

name change

We have __dag_get_proplist and __dag_set_proplist.

I like that.  Get and Set rhyme.

But we also have __get_node_revision and __put_node_revision.

"Put"?  

Can we change it to __set_node_revision?  Jimb?

    Looking for consistency,

       Ben

Re: name change

Posted by Jim Blandy <ji...@zwingli.cygnus.com>.

Ben Collins-Sussman <su...@newton.ch.collab.net> writes:
> We have __dag_get_proplist and __dag_set_proplist.
> 
> I like that.  Get and Set rhyme.
> 
> But we also have __get_node_revision and __put_node_revision.
> 
> "Put"?  
> 
> Can we change it to __set_node_revision?  Jimb?
> 
>     Looking for consistency,

Yes, that sounds like a good change.  We should all the following:

svn_fs__put_node_revision
svn_fs__put_rev
svn_fs__put_rep