You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by kjmrknsn <gi...@git.apache.org> on 2017/11/01 08:23:24 UTC
[GitHub] zeppelin pull request #2640: [ZEPPELIN-3022] The "Default Interpreter" selec...
GitHub user kjmrknsn opened a pull request:
https://github.com/apache/zeppelin/pull/2640
[ZEPPELIN-3022] The "Default Interpreter" select box on the "Create new note" modal dialog has no contents when it is opened via the "Create new note" link on ${ZEPPELIN_HOME}/webapps/webapp/app/home/notebook.html
### What is this PR for?
The "Default Interpreter" select box on the "Create new note" modal dialog has no contents when it is opened via the "Create new note" link on $
{ZEPPELIN_HOME}/webapps/webapp/app/home/notebook.html.
Fix $
{ZEPPELIN_HOME}/webapps/webapp/app/home/notebook.html so that NoteCreateCtrl.getInterpreterSettings() is invoked when the "Create new note" link is clicked.
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3022
### How should this be tested?
* Tested manually
* Before: "Default Interpreter" select box has no options
* <img width="1204" alt="zeppelin-3022_before" src="https://user-images.githubusercontent.com/31149688/32265997-daaad0ba-bf28-11e7-92d0-b0d53db25d7f.png">
* After: "Default Interpreter" select box has options successfully
* <img width="1209" alt="zeppelin-3022_after" src="https://user-images.githubusercontent.com/31149688/32266019-fcf4a5e2-bf28-11e7-8be3-7b02ace2d613.png">
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kjmrknsn/zeppelin ZEPPELIN-3022
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2640.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2640
----
commit ef4031de439fe895c5ea29dae9a24a21c776573f
Author: Keiji Yoshida <kj...@gmail.com>
Date: 2017-11-01T06:02:18Z
[ZEPPELIN-3022] The "Default Interpreter" select box on the "Create new note" modal dialog has no contents when it is opened via the "Create new note" link on ${ZEPPELIN_HOME}/webapps/webapp/app/home/notebook.html
----
---
[GitHub] zeppelin issue #2640: [ZEPPELIN-3022] The "Default Interpreter" select box o...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2640
Thanks @kjmrknsn. LGTM and Merge to master if no further comments
---
[GitHub] zeppelin issue #2640: [ZEPPELIN-3022] The "Default Interpreter" select box o...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2640
Thanks @kjmrknsn for the fix!
CI job 7.3 and 7.4 failed and looks like it's flaky test. https://travis-ci.org/kjmrknsn/zeppelin/builds/295636412
Could you try re-run failed tests and see if they goes green?
---
[GitHub] zeppelin pull request #2640: [ZEPPELIN-3022] The "Default Interpreter" selec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2640
---
[GitHub] zeppelin issue #2640: [ZEPPELIN-3022] The "Default Interpreter" select box o...
Posted by kjmrknsn <gi...@git.apache.org>.
Github user kjmrknsn commented on the issue:
https://github.com/apache/zeppelin/pull/2640
@Leemoonsoo The builds are rerun and passed. Thanks.
---