[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7550: Datasketches quantiles more post-aggs

[GitBox <gi...@apache.org>]

jon-wei commented on a change in pull request #7550: Datasketches quantiles more post-aggs
URL: https://github.com/apache/incubator-druid/pull/7550#discussion_r279132000
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/aggregation/AggregatorUtil.java
 ##########
 @@ -121,6 +121,10 @@
   public static final byte MOMENTS_SKETCH_BUILD_CACHE_TYPE_ID = 0x36;
   public static final byte MOMENTS_SKETCH_MERGE_CACHE_TYPE_ID = 0x37;
 
+  // Datasketches Quantiles sketch aggregator (part 2)
+  public static final byte QUANTILES_DOUBLES_SKETCH_TO_RANK_CACHE_TYPE_ID = 0x38;
 
 Review comment:
   Although some of the other sketch postaggs have IDs here, the postagg IDs should really go in `PostAggregatorIds`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org