You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/21 08:05:12 UTC
[GitHub] [incubator-superset] lily-liu opened a new issue #11356: SQL Statement on QUERY_LOGGER prints none to log
lily-liu opened a new issue #11356:
URL: https://github.com/apache/incubator-superset/issues/11356
`log_query` function on sql_lab.py passes `query.executed_sql` instead of `query.sql`, thus causing it to print TypeNone on log. This issue only happened when QUERY_LOGGER property is configured.
### Expected results
actual SQL statement string from sql_lab printed on the log
### Actual results
TypeNone printed on logfile
#### Screenshots
<img width="1440" alt="Screen Shot 2020-10-21 at 14 53 49" src="https://user-images.githubusercontent.com/23091708/96690692-34712680-13ae-11eb-9021-7c08e7aeff37.png">
#### How to reproduce the bug
1. Set QUERY_LOGGER property on to function that will log the query (e.g.
`def log_sql_statements(database, query, schema, user, client, security_manager, log_params):
logger.info("query is:" + str(query))
QUERY_LOGGER = log_sql_statements`
2. run any query from sql_lab
3. check the log on terminal
### Environment
- superset version: `0.37.2`
- python version: `3.6.0`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Superset runs on Ubuntu 18.04 VM, Host machine is macOS 10.15.7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11356: SQL Statement on QUERY_LOGGER prints none to log
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11356:
URL: https://github.com/apache/incubator-superset/issues/11356#issuecomment-713388386
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.97. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #11356: SQL Statement on QUERY_LOGGER prints none to log
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #11356:
URL: https://github.com/apache/incubator-superset/issues/11356#issuecomment-751276443
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org