[jira] [Comment Edited] (SOLR-9360) Solr script not properly checking SOLR_PID

["Erick Erickson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634685#comment-15634685 ] 

Erick Erickson edited comment on SOLR-9360 at 11/4/16 2:52 AM:
---------------------------------------------------------------

Oh, and the script _does_ use a pid file(s), this is a bit of extra logic using these patterns.



was (Author: erickerickson):
Oh, and the script _does_ use a pid file, these patterns are only examined as a fallback for stopping Solr and in the loop waiting up to 30 seconds to see solr loop. You wouldn't want to use the pid file there anyway as it might just be a leftover.....

FWIW.

> Solr script not properly checking SOLR_PID
> ------------------------------------------
>
>                 Key: SOLR-9360
>                 URL: https://issues.apache.org/jira/browse/SOLR-9360
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: scripts and tools
>    Affects Versions: 6.1
>            Reporter: Alessandro Benedetti
>            Assignee: Erick Erickson
>         Attachments: SOLR_9360.patch
>
>
> In the solr script we see in 3-4 areas  this check :
> SOLR_PID=`ps auxww | grep start\.jar | grep -w $SOLR_PORT | grep -v grep | awk '{print $2}' | sort -r`
> This can potentially prevent a solr instance to start in the case another process by any chance contains the port int the command itself ( not necessarily actually using the port) .
> e.g.
> java -server -Djetty.port=10504 -DSTOP.PORT=9504 -DSTOP.KEY=solrrocks -DMASTER_CORE_URL=external-server:10500/solr -jar start.jar --module=http
> A solr is running on 10504.
> A new Solr will not be able to start on 10500 ( but actually the port is free).
> This should be replaced by a real check if the port is used ( like netstat or similar) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org