You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/09/28 13:30:42 UTC

[GitHub] [tinkerpop] spmallette commented on pull request #1334: TINKERPOP-2427 Simplify Netty reference counting

spmallette commented on pull request #1334:
URL: https://github.com/apache/tinkerpop/pull/1334#issuecomment-700007900


   Glad you were able to improve this code. The `ctx.fireChannelRead(frame.retain(2));` always bugged me. I'd recommend that you merge to `master` and run tests before merging this as I think you will find some conflict there
   
   VOTE +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org