[GitHub] [ozone] sumitagrawl commented on a diff in pull request #4029: HDDS-7483. DN do not remove blocks for deleted content

["sumitagrawl (via GitHub)" <gi...@apache.org>]

sumitagrawl commented on code in PR #4029:
URL: https://github.com/apache/ozone/pull/4029#discussion_r1098146752


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RWBatchOperation.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.hadoop.hdds.utils.db;
+
+import java.io.IOException;
+import org.apache.hadoop.hdds.utils.db.managed.ManagedRocksIterator;
+import org.rocksdb.ColumnFamilyHandle;
+
+/**
+ * Class represents a read write batch operation,
+ * collects multiple db operation.
+ */
+public interface RWBatchOperation extends BatchOperation {
+  ManagedRocksIterator newIteratorWithBase(
+      ColumnFamilyHandle handle, ManagedRocksIterator newIterator)
+      throws IOException;
+
+  void lockOperation() throws IOException;
+  
+  void releaseOperation();

Review Comment:
   @errose28 
   Error is observed only while closed, tested and verified that flush do not have any impact and do not need block. Same concurrent test is done with flush and close for long time, and no issue is observed while flush. (Only closed have issue and fixed same here)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org