You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by 黑猪 <bl...@dingtalk.com.INVALID> on 2022/12/06 13:58:02 UTC
[DISCUSS] the bug with column lost comment
[DISCUSS]
i want to fix the bug with column lost comment,And I have some ideas, use the new ResolvedSchema to be compatible with existing usage systems while ensuring that the original tableSchema is unchanged.From flink's existing conception, the new object should be mature, so why not switch to the latest ResolvedSchema?
Re: [DISCUSS] the bug with column lost comment
Posted by yuxia <lu...@alumni.sjtu.edu.cn>.
The connectors are expected to migrate to new schema framwork. And it's in the plan that migrate TableSchema to new schema framwork Hive connector[1]
[1] https://issues.apache.org/jira/browse/FLINK-29585
Best regards,
Yuxia
----- 原始邮件 -----
发件人: "李宇彬" <li...@163.com>
收件人: "dev" <de...@flink.apache.org>
抄送: "dev" <de...@flink.apache.org>
发送时间: 星期三, 2022年 12 月 07日 下午 8:55:26
主题: Re: [DISCUSS] the bug with column lost comment
Hi,
in fact, the ability to get column comment rely on the new schema framework, until now, created table just provide deprecated `TableSchema`, so the merge request also take effect in your version.
On 12/7/2022 19:38，黑猪<bl...@dingtalk.com.INVALID> wrote：
I looked at this commit, not knowing if it is a different version, the commit is different from problem I encountered in flink1.14.3
------------------------------------------------------------------
发件人：Jingsong Li <ji...@gmail.com>
发送时间：2022年12月7日(星期三) 18:38
收件人：dev <de...@flink.apache.org>
主 题：Re: [DISCUSS] the bug with column lost comment
Hi,
https://github.com/apache/flink/pull/21182 is being reviewed.
You can take a look.
Best,
Jingsong
On Wed, Dec 7, 2022 at 4:46 PM 黑猪 <bl...@dingtalk.com.invalid> wrote:
[DISCUSS]
i want to fix the bug with column lost comment,And I have some ideas, use the new ResolvedSchema to be compatible with existing usage systems while ensuring that the original tableSchema is unchanged.From flink's existing conception, the new object should be mature, so why not switch to the latest ResolvedSchema?
Re: [DISCUSS] the bug with column lost comment
Posted by 李宇彬 <li...@163.com>.
Hi,
in fact, the ability to get column comment rely on the new schema framework, until now, created table just provide deprecated `TableSchema`, so the merge request also take effect in your version.
On 12/7/2022 19:38，黑猪<bl...@dingtalk.com.INVALID> wrote：
I looked at this commit, not knowing if it is a different version, the commit is different from problem I encountered in flink1.14.3
------------------------------------------------------------------
发件人：Jingsong Li <ji...@gmail.com>
发送时间：2022年12月7日(星期三) 18:38
收件人：dev <de...@flink.apache.org>
主 题：Re: [DISCUSS] the bug with column lost comment
Hi,
https://github.com/apache/flink/pull/21182 is being reviewed.
You can take a look.
Best,
Jingsong
On Wed, Dec 7, 2022 at 4:46 PM 黑猪 <bl...@dingtalk.com.invalid> wrote:
[DISCUSS]
i want to fix the bug with column lost comment,And I have some ideas, use the new ResolvedSchema to be compatible with existing usage systems while ensuring that the original tableSchema is unchanged.From flink's existing conception, the new object should be mature, so why not switch to the latest ResolvedSchema?
回复：[DISCUSS] the bug with column lost comment
Posted by 黑猪 <bl...@dingtalk.com.INVALID>.
I looked at this commit, not knowing if it is a different version, the commit is different from problem I encountered in flink1.14.3
------------------------------------------------------------------
发件人：Jingsong Li <ji...@gmail.com>
发送时间：2022年12月7日(星期三) 18:38
收件人：dev <de...@flink.apache.org>
主 题：Re: [DISCUSS] the bug with column lost comment
Hi,
https://github.com/apache/flink/pull/21182 is being reviewed.
You can take a look.
Best,
Jingsong
On Wed, Dec 7, 2022 at 4:46 PM 黑猪 <bl...@dingtalk.com.invalid> wrote:
>
> [DISCUSS]
> i want to fix the bug with column lost comment,And I have some ideas, use the new ResolvedSchema to be compatible with existing usage systems while ensuring that the original tableSchema is unchanged.From flink's existing conception, the new object should be mature, so why not switch to the latest ResolvedSchema?
Re: [DISCUSS] the bug with column lost comment
Posted by Jingsong Li <ji...@gmail.com>.
Hi,
https://github.com/apache/flink/pull/21182 is being reviewed.
You can take a look.
Best,
Jingsong
On Wed, Dec 7, 2022 at 4:46 PM 黑猪 <bl...@dingtalk.com.invalid> wrote:
>
> [DISCUSS]
> i want to fix the bug with column lost comment,And I have some ideas, use the new ResolvedSchema to be compatible with existing usage systems while ensuring that the original tableSchema is unchanged.From flink's existing conception, the new object should be mature, so why not switch to the latest ResolvedSchema?