You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2023/01/12 10:37:45 UTC
[GitHub] [lucene] jpountz opened a new pull request, #12079: Speed up 1D BKD merging.
jpountz opened a new pull request, #12079:
URL: https://github.com/apache/lucene/pull/12079
On the NYC taxis dataset on my local machine, switching from `Arrays#compareUnsigned` to `ArrayUtil#getUnsignedComparator` yielded a 15% speedup of BKD merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz merged pull request #12079: Speed up 1D BKD merging.
Posted by GitBox <gi...@apache.org>.
jpountz merged PR #12079:
URL: https://github.com/apache/lucene/pull/12079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #12079: Speed up 1D BKD merging.
Posted by GitBox <gi...@apache.org>.
jpountz commented on PR #12079:
URL: https://github.com/apache/lucene/pull/12079#issuecomment-1380286154
I remember thinking about it, and there are legitimate use-cases for `Arrays#compareUnsigned` like `BytesRef#compareTo`. Another thing is that `ArrayUtil#getUnsignedComparator` only helps if we expect the lengths to compare to be commonly 4 or 8, otherwise it just wraps `Arrays#compareUnsigned`. But to your point, maybe we could do another round or review of all call sites or `Arrays#compareUnsigned` to see if there are some of them that should switch to `ArrayUtil#getUnsignedComparator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] iverase commented on pull request #12079: Speed up 1D BKD merging.
Posted by GitBox <gi...@apache.org>.
iverase commented on PR #12079:
URL: https://github.com/apache/lucene/pull/12079#issuecomment-1380193686
I wonder if we should add `Arrays.compareUnsigned` to forbidden APIs to force always to use the faster comparators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #12079: Speed up 1D BKD merging.
Posted by GitBox <gi...@apache.org>.
jpountz commented on PR #12079:
URL: https://github.com/apache/lucene/pull/12079#issuecomment-1382690674
The last data point at https://people.apache.org/~mikemccand/lucenebench/sparseResults.html#tot_merge_times has a drop for overall merging that I expect to be mostly contributed by this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org