You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/27 11:51:42 UTC

[GitHub] [hbase] cuibo01 commented on a change in pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

cuibo01 commented on a change in pull request #2313:
URL: https://github.com/apache/hbase/pull/2313#discussion_r478357545



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -488,6 +496,8 @@ protected boolean isMatchingRegionLocation(RegionStateNode rsn) {
    */
   private void assignRegions(MasterProcedureEnv env, List<RegionInfo> regions) throws IOException {
     AssignmentManager am = env.getMasterServices().getAssignmentManager();
+    boolean retainAssignment = env.getMasterConfiguration().getBoolean(SCP_RETAIN_ASSIGNMENT,

Review comment:
       we should also check whether the current servername is online.
   like "isServerWithSameHostnamePortOnline"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org