You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2012/07/11 16:28:36 UTC
[jira] [Created] (HADOOP-8588) SerializationFactory shouldn't throw
a NullPointerException if the serializations list is empty
Harsh J created HADOOP-8588:
-------------------------------
Summary: SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
Key: HADOOP-8588
URL: https://issues.apache.org/jira/browse/HADOOP-8588
Project: Hadoop Common
Issue Type: Improvement
Components: io
Affects Versions: 2.0.0-alpha
Reporter: Harsh J
Priority: Minor
The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8588) SerializationFactory shouldn't throw
a NullPointerException if the serializations list is empty
Posted by "Sho Shimauchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sho Shimauchi updated HADOOP-8588:
----------------------------------
Attachment: HADOOP-8588.txt
Attached patch check the value of CommonConfigurationKeys.IO_SERIALIZATIONS_KEY before conf.getStrings() is run.
Also I refactord test methods to cover all codes in SerializationFactory class.
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8588) SerializationFactory shouldn't throw
a NullPointerException if the serializations list is empty
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-8588:
----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Sorry, meant to mark as resolved.
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8588.txt, HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8588) SerializationFactory shouldn't throw
a NullPointerException if the serializations list is empty
Posted by "Sho Shimauchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sho Shimauchi updated HADOOP-8588:
----------------------------------
Status: Open (was: Patch Available)
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Attachments: HADOOP-8588.txt, HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8588) SerializationFactory shouldn't
throw a NullPointerException if the serializations list is empty
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461422#comment-13461422 ]
Hudson commented on HADOOP-8588:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1205 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1205/])
HADOOP-8588. SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty. Contributed by Sho Shimauchi. (harsh) (Revision 1389002)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389002
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/serializer/TestSerializationFactory.java
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8588.txt, HADOOP-8588.txt, HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8588) SerializationFactory shouldn't throw
a NullPointerException if the serializations list is empty
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-8588:
----------------------------
Fix Version/s: 3.0.0
Hadoop Flags: Reviewed
Status: Patch Available (was: Open)
Thanks much Sho, I verified the tests locally and have committed this to trunk (r1389002).
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8588.txt, HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-8588) SerializationFactory shouldn't
throw a NullPointerException if the serializations list is empty
Posted by "Sho Shimauchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sho Shimauchi reassigned HADOOP-8588:
-------------------------------------
Assignee: Sho Shimauchi
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Labels: newbie
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8588) SerializationFactory shouldn't
throw a NullPointerException if the serializations list is empty
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461324#comment-13461324 ]
Harsh J commented on HADOOP-8588:
---------------------------------
Sorry for the late review Sho, I'd been busy. Some comments:
{code}
+ if (conf.get(CommonConfigurationKeys.IO_SERIALIZATIONS_KEY) == "") {
{code}
The double equal-to seems wrong to compare strings? Can we use .isEmpty() or .equals() instead? May also be worth having a Configuration method that checks for existence and for emptiness rather than us always comparing if it has one manually like this all the time (but this is just a nit, lets do it in another JIRA if agreed, that doesn't depend on the patch here).
{code}
+ public void testGetDesirializer() {
{code}
s/Desirializer/Deserializer
{code}
LOG.warn(CommonConfigurationKeys.IO_SERIALIZATIONS_KEY
+ + " is empty. start up without any valid serialization classes.");
{code}
Maybe this can be refined to: "Serialization for various data types may not be available. Please configure X properly to have serialization support (it is currently not set)."?
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Attachments: HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8588) SerializationFactory shouldn't
throw a NullPointerException if the serializations list is empty
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461323#comment-13461323 ]
Hadoop QA commented on HADOOP-8588:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541518/HADOOP-8588.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1502//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1502//console
This message is automatically generated.
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8588) SerializationFactory shouldn't throw
a NullPointerException if the serializations list is empty
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-8588:
----------------------------
Attachment: HADOOP-8588.txt
Attaching committed patch as I had also cleaned up a couple of whitespace and one relevant indentation fix while committing.
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8588.txt, HADOOP-8588.txt, HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8588) SerializationFactory shouldn't throw
a NullPointerException if the serializations list is empty
Posted by "Sho Shimauchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sho Shimauchi updated HADOOP-8588:
----------------------------------
Status: Patch Available (was: Open)
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8588) SerializationFactory shouldn't
throw a NullPointerException if the serializations list is empty
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461412#comment-13461412 ]
Hudson commented on HADOOP-8588:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1174 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1174/])
HADOOP-8588. SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty. Contributed by Sho Shimauchi. (harsh) (Revision 1389002)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389002
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/serializer/TestSerializationFactory.java
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8588.txt, HADOOP-8588.txt, HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8588) SerializationFactory shouldn't
throw a NullPointerException if the serializations list is empty
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461389#comment-13461389 ]
Hudson commented on HADOOP-8588:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2779 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2779/])
HADOOP-8588. SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty. Contributed by Sho Shimauchi. (harsh) (Revision 1389002)
Result = FAILURE
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389002
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/serializer/TestSerializationFactory.java
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8588.txt, HADOOP-8588.txt, HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8588) SerializationFactory shouldn't
throw a NullPointerException if the serializations list is empty
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461372#comment-13461372 ]
Hudson commented on HADOOP-8588:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2757 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2757/])
HADOOP-8588. SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty. Contributed by Sho Shimauchi. (harsh) (Revision 1389002)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389002
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/serializer/TestSerializationFactory.java
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8588.txt, HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8588) SerializationFactory shouldn't
throw a NullPointerException if the serializations list is empty
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461374#comment-13461374 ]
Hudson commented on HADOOP-8588:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2820 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2820/])
HADOOP-8588. SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty. Contributed by Sho Shimauchi. (harsh) (Revision 1389002)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389002
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/serializer/TestSerializationFactory.java
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8588.txt, HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8588) SerializationFactory shouldn't throw
a NullPointerException if the serializations list is empty
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-8588:
----------------------------
Labels: (was: newbie)
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Attachments: HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8588) SerializationFactory shouldn't throw
a NullPointerException if the serializations list is empty
Posted by "Sho Shimauchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sho Shimauchi updated HADOOP-8588:
----------------------------------
Attachment: HADOOP-8588.txt
Thanks Harsh!
I updated the patch.
{quote}
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
{quote}
This test timed out but it seems nothing to do with my patch.
> SerializationFactory shouldn't throw a NullPointerException if the serializations list is empty
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8588
> URL: https://issues.apache.org/jira/browse/HADOOP-8588
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Sho Shimauchi
> Priority: Minor
> Attachments: HADOOP-8588.txt, HADOOP-8588.txt
>
>
> The SerializationFactory throws an NPE if CommonConfigurationKeys.IO_SERIALIZATIONS_KEY is set to an empty list in the config.
> It should rather print a WARN log indicating the serializations list is empty, and start up without any valid serialization classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira