You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "extinguish (via GitHub)" <gi...@apache.org> on 2026/01/14 12:42:51 UTC

[PR] libuv: fix sendmsg parameter type in NuttX port [nuttx-apps]

extinguish opened a new pull request, #3324:
URL: https://github.com/apache/nuttx-apps/pull/3324

   ## Summary
   
   Update the sendmsg() stub implementation in the libuv NuttX port (src/unix/nuttx.c) to match the POSIX‑compliant signature by changing the msg parameter from struct msghdr * to const struct msghdr *. This change synchronizes the libuv port with the recent NuttX socket API update.
   
   ## Impact
   
   1. Ensures the libuv NuttX port compiles cleanly with the updated NuttX socket headers.
   2. Maintains type consistency between libuv and the underlying NuttX socket API.
   3. No functional change—the stub still returns UV_ENOTSUP as before.
   
   ## Testing
   
   Verified that the modified libuv patch applies successfully and compiles without type‑mismatch warnings.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] libuv: fix sendmsg parameter type in NuttX port [nuttx-apps]

Posted by "extinguish (via GitHub)" <gi...@apache.org>.
extinguish commented on PR #3324:
URL: https://github.com/apache/nuttx-apps/pull/3324#issuecomment-3752547109

   > still some typos? :-P
   
   the error info are:
   ```
   /home/runner/work/nuttx-apps/nuttx-apps/apps/system/libuv/0001-libuv-port-for-nuttx.patch:3490: PASE ==> PASS, PACE, PARSE
   ```
   but the `PASE` is a trademark, not a valid English word, how can skip this single word check ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] libuv: fix sendmsg parameter type in NuttX port [nuttx-apps]

Posted by "extinguish (via GitHub)" <gi...@apache.org>.
extinguish commented on code in PR #3324:
URL: https://github.com/apache/nuttx-apps/pull/3324#discussion_r2692698742


##########
system/libuv/0001-libuv-port-for-nuttx.patch:
##########
@@ -3487,7 +3487,7 @@ index bbc0c305..4e7996f5 100644
 -#if defined(__CYGWIN__) || defined(__MSYS__) || defined(__PASE__)
 +#if defined(__CYGWIN__) || defined(__MSYS__) || defined(__PASE__) || defined(__NuttX__)
  /* Cygwin crashes or hangs in socket() with too many AF_INET sockets.  */
- /* IBMi PASE timeout with too many AF_INET sockets.  */
+ /* IBMi PASS timeout with too many AF_INET sockets.  */

Review Comment:
   > restore IBMi PASE is a trademark
   
   fixed in new patchset, but the precheck report error as:
   ```
   /home/runner/work/nuttx-apps/nuttx-apps/apps/system/libuv/0001-libuv-port-for-nuttx.patch:3490: PASE ==> PASS, PACE, PARSE
   ```
   
   should we skip this check on this patch?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] libuv: fix sendmsg parameter type in NuttX port [nuttx-apps]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #3324:
URL: https://github.com/apache/nuttx-apps/pull/3324#discussion_r2691415136


##########
system/libuv/0001-libuv-port-for-nuttx.patch:
##########
@@ -3487,7 +3487,7 @@ index bbc0c305..4e7996f5 100644
 -#if defined(__CYGWIN__) || defined(__MSYS__) || defined(__PASE__)
 +#if defined(__CYGWIN__) || defined(__MSYS__) || defined(__PASE__) || defined(__NuttX__)
  /* Cygwin crashes or hangs in socket() with too many AF_INET sockets.  */
- /* IBMi PASE timeout with too many AF_INET sockets.  */
+ /* IBMi PASS timeout with too many AF_INET sockets.  */

Review Comment:
   restore IBMi PASE is a trademark



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] libuv: fix sendmsg parameter type in NuttX port [nuttx-apps]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #3324:
URL: https://github.com/apache/nuttx-apps/pull/3324


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] libuv: fix sendmsg parameter type in NuttX port [nuttx-apps]

Posted by "extinguish (via GitHub)" <gi...@apache.org>.
extinguish commented on code in PR #3324:
URL: https://github.com/apache/nuttx-apps/pull/3324#discussion_r2692698742


##########
system/libuv/0001-libuv-port-for-nuttx.patch:
##########
@@ -3487,7 +3487,7 @@ index bbc0c305..4e7996f5 100644
 -#if defined(__CYGWIN__) || defined(__MSYS__) || defined(__PASE__)
 +#if defined(__CYGWIN__) || defined(__MSYS__) || defined(__PASE__) || defined(__NuttX__)
  /* Cygwin crashes or hangs in socket() with too many AF_INET sockets.  */
- /* IBMi PASE timeout with too many AF_INET sockets.  */
+ /* IBMi PASS timeout with too many AF_INET sockets.  */

Review Comment:
   > restore IBMi PASE is a trademark
   
   fixed in new patchset



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] libuv: fix sendmsg parameter type in NuttX port [nuttx-apps]

Posted by "cederom (via GitHub)" <gi...@apache.org>.
cederom commented on PR #3324:
URL: https://github.com/apache/nuttx-apps/pull/3324#issuecomment-3752544498

   still some typos? :-P 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] libuv: fix sendmsg parameter type in NuttX port [nuttx-apps]

Posted by "extinguish (via GitHub)" <gi...@apache.org>.
extinguish commented on PR #3324:
URL: https://github.com/apache/nuttx-apps/pull/3324#issuecomment-3749410307

   this patch need to build together with https://github.com/apache/nuttx-apps/pull/3324


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org