You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by gr...@apache.org on 2019/07/31 01:05:32 UTC

[royale-asjs] 01/02: Specifying these dependencies in maven was necessary to get build working locally.

This is an automated email from the ASF dual-hosted git repository.

gregdove pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit 9010ab1fe8ede921541f212d7da850b23fc3aa88
Author: greg-dove <gr...@gmail.com>
AuthorDate: Wed Jul 31 12:44:55 2019 +1200

    Specifying these dependencies in maven was necessary to get build working locally.
---
 frameworks/projects/DragDrop/pom.xml | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/frameworks/projects/DragDrop/pom.xml b/frameworks/projects/DragDrop/pom.xml
index d4ba4e4..9d14ed5 100644
--- a/frameworks/projects/DragDrop/pom.xml
+++ b/frameworks/projects/DragDrop/pom.xml
@@ -86,6 +86,34 @@
         <type>swc</type>
         <classifier>js</classifier>
     </dependency>
+    <dependency>
+      <groupId>org.apache.royale.framework</groupId>
+      <artifactId>Collections</artifactId>
+      <version>0.9.6-SNAPSHOT</version>
+      <type>swc</type>
+      <classifier>swf</classifier>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.royale.framework</groupId>
+      <artifactId>Collections</artifactId>
+      <version>0.9.6-SNAPSHOT</version>
+      <type>swc</type>
+      <classifier>js</classifier>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.royale.framework</groupId>
+      <artifactId>Graphics</artifactId>
+      <version>0.9.6-SNAPSHOT</version>
+      <type>swc</type>
+      <classifier>swf</classifier>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.royale.framework</groupId>
+      <artifactId>Graphics</artifactId>
+      <version>0.9.6-SNAPSHOT</version>
+      <type>swc</type>
+      <classifier>js</classifier>
+    </dependency>
   </dependencies>
 
 </project>


Re: [royale-asjs] 01/02: Specifying these dependencies in maven was necessary to get build working locally.

Posted by Alex Harui <ah...@adobe.com.INVALID>.
I'm not sure Maven is smart about changing versions stored in properties.  I think that's one reason the version is explicit in the dependency.  It seems redundant to us because we have many SWCs all of the same version, but in other POMs the version of each dependency might be different.

Of course, I could be wrong...
-Alex

On 7/31/19, 12:20 AM, "Carlos Rovira" <ca...@apache.org> wrote:

    If we don't have that way we should since that will make all versions
    update process more easy and with less errors
    
    Thanks
    
    El El mié, 31 jul 2019 a las 8:33, Piotr Zarzycki <pi...@gmail.com>
    escribió:
    
    > No worries I was just wondering without looking into other poms whether we
    > actually not using anything already.
    >
    > On Wed, Jul 31, 2019, 8:23 AM Greg Dove <gr...@gmail.com> wrote:
    >
    > > Hi Piotr,
    > >
    > > I'm not sure, but if there isn't I assume it will be easy to swap things
    > > out to do that. I'm AFK now, but I can take a look at that tomorrow.
    > >
    > >
    > >
    > > On Wed, 31 Jul 2019, 17:55 Piotr Zarzycki, <pi...@gmail.com>
    > > wrote:
    > >
    > > > Hi Greg,
    > > >
    > > > Is there any kind of global variable where version of Royale is
    > specified
    > > > instead hardcoded?
    > > >
    > > > Thanks,
    > > > Piotr
    > > >
    > > > On Wed, Jul 31, 2019, 3:05 AM <gr...@apache.org> wrote:
    > > >
    > > > > This is an automated email from the ASF dual-hosted git repository.
    > > > >
    > > > > gregdove pushed a commit to branch develop
    > > > > in repository https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Cad150185a0f74d7dcc9308d715879e6e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637001544534772039&amp;sdata=7a9vw4VHPxc1IDilS9cD%2F8fqYhbiQijz3xjrZXhm2dw%3D&amp;reserved=0
    > > > >
    > > > > commit 9010ab1fe8ede921541f212d7da850b23fc3aa88
    > > > > Author: greg-dove <gr...@gmail.com>
    > > > > AuthorDate: Wed Jul 31 12:44:55 2019 +1200
    > > > >
    > > > >     Specifying these dependencies in maven was necessary to get build
    > > > > working locally.
    > > > > ---
    > > > >  frameworks/projects/DragDrop/pom.xml | 28
    > ++++++++++++++++++++++++++++
    > > > >  1 file changed, 28 insertions(+)
    > > > >
    > > > > diff --git a/frameworks/projects/DragDrop/pom.xml
    > > > > b/frameworks/projects/DragDrop/pom.xml
    > > > > index d4ba4e4..9d14ed5 100644
    > > > > --- a/frameworks/projects/DragDrop/pom.xml
    > > > > +++ b/frameworks/projects/DragDrop/pom.xml
    > > > > @@ -86,6 +86,34 @@
    > > > >          <type>swc</type>
    > > > >          <classifier>js</classifier>
    > > > >      </dependency>
    > > > > +    <dependency>
    > > > > +      <groupId>org.apache.royale.framework</groupId>
    > > > > +      <artifactId>Collections</artifactId>
    > > > > +      <version>0.9.6-SNAPSHOT</version>
    > > > > +      <type>swc</type>
    > > > > +      <classifier>swf</classifier>
    > > > > +    </dependency>
    > > > > +    <dependency>
    > > > > +      <groupId>org.apache.royale.framework</groupId>
    > > > > +      <artifactId>Collections</artifactId>
    > > > > +      <version>0.9.6-SNAPSHOT</version>
    > > > > +      <type>swc</type>
    > > > > +      <classifier>js</classifier>
    > > > > +    </dependency>
    > > > > +    <dependency>
    > > > > +      <groupId>org.apache.royale.framework</groupId>
    > > > > +      <artifactId>Graphics</artifactId>
    > > > > +      <version>0.9.6-SNAPSHOT</version>
    > > > > +      <type>swc</type>
    > > > > +      <classifier>swf</classifier>
    > > > > +    </dependency>
    > > > > +    <dependency>
    > > > > +      <groupId>org.apache.royale.framework</groupId>
    > > > > +      <artifactId>Graphics</artifactId>
    > > > > +      <version>0.9.6-SNAPSHOT</version>
    > > > > +      <type>swc</type>
    > > > > +      <classifier>js</classifier>
    > > > > +    </dependency>
    > > > >    </dependencies>
    > > > >
    > > > >  </project>
    > > > >
    > > > >
    > > >
    > >
    >
    -- 
    Carlos Rovira
    https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&amp;data=02%7C01%7Caharui%40adobe.com%7Cad150185a0f74d7dcc9308d715879e6e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637001544534772039&amp;sdata=LrDDLEmCNnlvHryVE3q%2FpDyIhpIMnNjdxnNAE2AQdsk%3D&amp;reserved=0
    


Re: [royale-asjs] 01/02: Specifying these dependencies in maven was necessary to get build working locally.

Posted by Carlos Rovira <ca...@apache.org>.
If we don't have that way we should since that will make all versions
update process more easy and with less errors

Thanks

El El mié, 31 jul 2019 a las 8:33, Piotr Zarzycki <pi...@gmail.com>
escribió:

> No worries I was just wondering without looking into other poms whether we
> actually not using anything already.
>
> On Wed, Jul 31, 2019, 8:23 AM Greg Dove <gr...@gmail.com> wrote:
>
> > Hi Piotr,
> >
> > I'm not sure, but if there isn't I assume it will be easy to swap things
> > out to do that. I'm AFK now, but I can take a look at that tomorrow.
> >
> >
> >
> > On Wed, 31 Jul 2019, 17:55 Piotr Zarzycki, <pi...@gmail.com>
> > wrote:
> >
> > > Hi Greg,
> > >
> > > Is there any kind of global variable where version of Royale is
> specified
> > > instead hardcoded?
> > >
> > > Thanks,
> > > Piotr
> > >
> > > On Wed, Jul 31, 2019, 3:05 AM <gr...@apache.org> wrote:
> > >
> > > > This is an automated email from the ASF dual-hosted git repository.
> > > >
> > > > gregdove pushed a commit to branch develop
> > > > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> > > >
> > > > commit 9010ab1fe8ede921541f212d7da850b23fc3aa88
> > > > Author: greg-dove <gr...@gmail.com>
> > > > AuthorDate: Wed Jul 31 12:44:55 2019 +1200
> > > >
> > > >     Specifying these dependencies in maven was necessary to get build
> > > > working locally.
> > > > ---
> > > >  frameworks/projects/DragDrop/pom.xml | 28
> ++++++++++++++++++++++++++++
> > > >  1 file changed, 28 insertions(+)
> > > >
> > > > diff --git a/frameworks/projects/DragDrop/pom.xml
> > > > b/frameworks/projects/DragDrop/pom.xml
> > > > index d4ba4e4..9d14ed5 100644
> > > > --- a/frameworks/projects/DragDrop/pom.xml
> > > > +++ b/frameworks/projects/DragDrop/pom.xml
> > > > @@ -86,6 +86,34 @@
> > > >          <type>swc</type>
> > > >          <classifier>js</classifier>
> > > >      </dependency>
> > > > +    <dependency>
> > > > +      <groupId>org.apache.royale.framework</groupId>
> > > > +      <artifactId>Collections</artifactId>
> > > > +      <version>0.9.6-SNAPSHOT</version>
> > > > +      <type>swc</type>
> > > > +      <classifier>swf</classifier>
> > > > +    </dependency>
> > > > +    <dependency>
> > > > +      <groupId>org.apache.royale.framework</groupId>
> > > > +      <artifactId>Collections</artifactId>
> > > > +      <version>0.9.6-SNAPSHOT</version>
> > > > +      <type>swc</type>
> > > > +      <classifier>js</classifier>
> > > > +    </dependency>
> > > > +    <dependency>
> > > > +      <groupId>org.apache.royale.framework</groupId>
> > > > +      <artifactId>Graphics</artifactId>
> > > > +      <version>0.9.6-SNAPSHOT</version>
> > > > +      <type>swc</type>
> > > > +      <classifier>swf</classifier>
> > > > +    </dependency>
> > > > +    <dependency>
> > > > +      <groupId>org.apache.royale.framework</groupId>
> > > > +      <artifactId>Graphics</artifactId>
> > > > +      <version>0.9.6-SNAPSHOT</version>
> > > > +      <type>swc</type>
> > > > +      <classifier>js</classifier>
> > > > +    </dependency>
> > > >    </dependencies>
> > > >
> > > >  </project>
> > > >
> > > >
> > >
> >
>
-- 
Carlos Rovira
http://about.me/carlosrovira

Re: [royale-asjs] 01/02: Specifying these dependencies in maven was necessary to get build working locally.

Posted by Piotr Zarzycki <pi...@gmail.com>.
No worries I was just wondering without looking into other poms whether we
actually not using anything already.

On Wed, Jul 31, 2019, 8:23 AM Greg Dove <gr...@gmail.com> wrote:

> Hi Piotr,
>
> I'm not sure, but if there isn't I assume it will be easy to swap things
> out to do that. I'm AFK now, but I can take a look at that tomorrow.
>
>
>
> On Wed, 31 Jul 2019, 17:55 Piotr Zarzycki, <pi...@gmail.com>
> wrote:
>
> > Hi Greg,
> >
> > Is there any kind of global variable where version of Royale is specified
> > instead hardcoded?
> >
> > Thanks,
> > Piotr
> >
> > On Wed, Jul 31, 2019, 3:05 AM <gr...@apache.org> wrote:
> >
> > > This is an automated email from the ASF dual-hosted git repository.
> > >
> > > gregdove pushed a commit to branch develop
> > > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> > >
> > > commit 9010ab1fe8ede921541f212d7da850b23fc3aa88
> > > Author: greg-dove <gr...@gmail.com>
> > > AuthorDate: Wed Jul 31 12:44:55 2019 +1200
> > >
> > >     Specifying these dependencies in maven was necessary to get build
> > > working locally.
> > > ---
> > >  frameworks/projects/DragDrop/pom.xml | 28 ++++++++++++++++++++++++++++
> > >  1 file changed, 28 insertions(+)
> > >
> > > diff --git a/frameworks/projects/DragDrop/pom.xml
> > > b/frameworks/projects/DragDrop/pom.xml
> > > index d4ba4e4..9d14ed5 100644
> > > --- a/frameworks/projects/DragDrop/pom.xml
> > > +++ b/frameworks/projects/DragDrop/pom.xml
> > > @@ -86,6 +86,34 @@
> > >          <type>swc</type>
> > >          <classifier>js</classifier>
> > >      </dependency>
> > > +    <dependency>
> > > +      <groupId>org.apache.royale.framework</groupId>
> > > +      <artifactId>Collections</artifactId>
> > > +      <version>0.9.6-SNAPSHOT</version>
> > > +      <type>swc</type>
> > > +      <classifier>swf</classifier>
> > > +    </dependency>
> > > +    <dependency>
> > > +      <groupId>org.apache.royale.framework</groupId>
> > > +      <artifactId>Collections</artifactId>
> > > +      <version>0.9.6-SNAPSHOT</version>
> > > +      <type>swc</type>
> > > +      <classifier>js</classifier>
> > > +    </dependency>
> > > +    <dependency>
> > > +      <groupId>org.apache.royale.framework</groupId>
> > > +      <artifactId>Graphics</artifactId>
> > > +      <version>0.9.6-SNAPSHOT</version>
> > > +      <type>swc</type>
> > > +      <classifier>swf</classifier>
> > > +    </dependency>
> > > +    <dependency>
> > > +      <groupId>org.apache.royale.framework</groupId>
> > > +      <artifactId>Graphics</artifactId>
> > > +      <version>0.9.6-SNAPSHOT</version>
> > > +      <type>swc</type>
> > > +      <classifier>js</classifier>
> > > +    </dependency>
> > >    </dependencies>
> > >
> > >  </project>
> > >
> > >
> >
>

Re: [royale-asjs] 01/02: Specifying these dependencies in maven was necessary to get build working locally.

Posted by Greg Dove <gr...@gmail.com>.
Hi Piotr,

I'm not sure, but if there isn't I assume it will be easy to swap things
out to do that. I'm AFK now, but I can take a look at that tomorrow.



On Wed, 31 Jul 2019, 17:55 Piotr Zarzycki, <pi...@gmail.com>
wrote:

> Hi Greg,
>
> Is there any kind of global variable where version of Royale is specified
> instead hardcoded?
>
> Thanks,
> Piotr
>
> On Wed, Jul 31, 2019, 3:05 AM <gr...@apache.org> wrote:
>
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > gregdove pushed a commit to branch develop
> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >
> > commit 9010ab1fe8ede921541f212d7da850b23fc3aa88
> > Author: greg-dove <gr...@gmail.com>
> > AuthorDate: Wed Jul 31 12:44:55 2019 +1200
> >
> >     Specifying these dependencies in maven was necessary to get build
> > working locally.
> > ---
> >  frameworks/projects/DragDrop/pom.xml | 28 ++++++++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> >
> > diff --git a/frameworks/projects/DragDrop/pom.xml
> > b/frameworks/projects/DragDrop/pom.xml
> > index d4ba4e4..9d14ed5 100644
> > --- a/frameworks/projects/DragDrop/pom.xml
> > +++ b/frameworks/projects/DragDrop/pom.xml
> > @@ -86,6 +86,34 @@
> >          <type>swc</type>
> >          <classifier>js</classifier>
> >      </dependency>
> > +    <dependency>
> > +      <groupId>org.apache.royale.framework</groupId>
> > +      <artifactId>Collections</artifactId>
> > +      <version>0.9.6-SNAPSHOT</version>
> > +      <type>swc</type>
> > +      <classifier>swf</classifier>
> > +    </dependency>
> > +    <dependency>
> > +      <groupId>org.apache.royale.framework</groupId>
> > +      <artifactId>Collections</artifactId>
> > +      <version>0.9.6-SNAPSHOT</version>
> > +      <type>swc</type>
> > +      <classifier>js</classifier>
> > +    </dependency>
> > +    <dependency>
> > +      <groupId>org.apache.royale.framework</groupId>
> > +      <artifactId>Graphics</artifactId>
> > +      <version>0.9.6-SNAPSHOT</version>
> > +      <type>swc</type>
> > +      <classifier>swf</classifier>
> > +    </dependency>
> > +    <dependency>
> > +      <groupId>org.apache.royale.framework</groupId>
> > +      <artifactId>Graphics</artifactId>
> > +      <version>0.9.6-SNAPSHOT</version>
> > +      <type>swc</type>
> > +      <classifier>js</classifier>
> > +    </dependency>
> >    </dependencies>
> >
> >  </project>
> >
> >
>

Re: [royale-asjs] 01/02: Specifying these dependencies in maven was necessary to get build working locally.

Posted by Piotr Zarzycki <pi...@gmail.com>.
Hi Greg,

Is there any kind of global variable where version of Royale is specified
instead hardcoded?

Thanks,
Piotr

On Wed, Jul 31, 2019, 3:05 AM <gr...@apache.org> wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> gregdove pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
> commit 9010ab1fe8ede921541f212d7da850b23fc3aa88
> Author: greg-dove <gr...@gmail.com>
> AuthorDate: Wed Jul 31 12:44:55 2019 +1200
>
>     Specifying these dependencies in maven was necessary to get build
> working locally.
> ---
>  frameworks/projects/DragDrop/pom.xml | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/frameworks/projects/DragDrop/pom.xml
> b/frameworks/projects/DragDrop/pom.xml
> index d4ba4e4..9d14ed5 100644
> --- a/frameworks/projects/DragDrop/pom.xml
> +++ b/frameworks/projects/DragDrop/pom.xml
> @@ -86,6 +86,34 @@
>          <type>swc</type>
>          <classifier>js</classifier>
>      </dependency>
> +    <dependency>
> +      <groupId>org.apache.royale.framework</groupId>
> +      <artifactId>Collections</artifactId>
> +      <version>0.9.6-SNAPSHOT</version>
> +      <type>swc</type>
> +      <classifier>swf</classifier>
> +    </dependency>
> +    <dependency>
> +      <groupId>org.apache.royale.framework</groupId>
> +      <artifactId>Collections</artifactId>
> +      <version>0.9.6-SNAPSHOT</version>
> +      <type>swc</type>
> +      <classifier>js</classifier>
> +    </dependency>
> +    <dependency>
> +      <groupId>org.apache.royale.framework</groupId>
> +      <artifactId>Graphics</artifactId>
> +      <version>0.9.6-SNAPSHOT</version>
> +      <type>swc</type>
> +      <classifier>swf</classifier>
> +    </dependency>
> +    <dependency>
> +      <groupId>org.apache.royale.framework</groupId>
> +      <artifactId>Graphics</artifactId>
> +      <version>0.9.6-SNAPSHOT</version>
> +      <type>swc</type>
> +      <classifier>js</classifier>
> +    </dependency>
>    </dependencies>
>
>  </project>
>
>