You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2026/08/21 18:14:46 UTC
[PR] CAMEL-24411: camel-oauth - stop the route when the processors do not authenticate the request [camel]
oscerd opened a new pull request, #25567:
URL: https://github.com/apache/camel/pull/25567
Fixes [CAMEL-24411](https://issues.apache.org/jira/browse/CAMEL-24411).
## Problem
The camel-oauth processors return normally from `process()` on the paths where they do **not** authenticate the caller, so the remaining steps of the route still run — and overwrite the response the processor had just prepared. The component's own test routes have exactly that shape:
```java
from("platform-http:/bearer")
.process(new OAuthBearerTokenProcessor())
.setBody(simple("${body} - OAuthBearerToken"));
```
Three call sites are affected:
| Processor | Path | Before |
|---|---|---|
| `OAuthBearerTokenProcessor` | no `Authorization` header, or one that does not parse as `Bearer <token>` | `400` + return |
| `OAuthCodeFlowProcessor` | no authenticated session ⇒ redirect to the IdP | `302` + return |
| `OAuthCodeFlowCallback` | callback without the `code` parameter | `400` + return |
There is no `setRouteStop`, `CamelAuthorizationException` or `RoutePolicy` anywhere in camel-oauth `src/main`, so nothing halts the exchange on any of them.
Note the enforcement was also **inverted** in the bearer processor: a present-but-invalid token fails closed (the exception from `OAuth.authenticate()` propagates), while an *absent* credential did not.
## Change
Adds `reject()` and `rejectUnauthorized()` to `AbstractOAuthProcessor` and applies them at the three denial points. The bearer processor now answers `401` with a `WWW-Authenticate: Bearer` challenge (RFC 6750) rather than `400`.
**Deliberately left alone:** `sendRedirect()` itself, and `OAuthLogoutProcessor`. Making `sendRedirect` stop the route would have been the tidier change, but the shipped logout route
```java
from("servlet:/logout")
.process(new OAuthLogoutProcessor())
.process(exc -> exc.getContext().getGlobalOptions().put("OAuthLogout", "ok"));
```
relies on the step after the redirect running. Only the **denial** paths stop; authenticated requests continue through the rest of the route exactly as before.
## Testing
New `OAuthProcessorFailClosedTest` covers the three paths that return before any identity provider is contacted, so it needs no Keycloak container. Verified it catches the regression: **all 3 tests fail against the pre-fix code**, all 3 pass after.
```
mvn test -Dtest=OAuthProcessorFailClosedTest # 3 passed
mvn clean install -DskipTests # full reactor, BUILD SUCCESS
```
Adds a test-scoped `assertj-core` to camel-oauth, which the module was missing (project convention is AssertJ for new test code).
## Backport
Intended for **camel-4.22.x, camel-4.18.x and camel-4.14.x**. It is a behaviour change, but it is the behaviour of an authentication gate, and camel-oauth is a Preview-support component. The upgrade-guide entry stays on `main` per the project's guide policy.
---
_Claude Code on behalf of
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24411: camel-oauth - stop the route when the processors do not authenticate the request [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25567:
URL: https://github.com/apache/camel/pull/25567#issuecomment-5373869054
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `components/camel-oauth`
- `docs`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 10 tested, 28 compile-only — current: 9 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **38 affected modules** (current approach: 9).
<details><summary>:warning: Modules only in Scalpel (29)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog`
- `camel-catalog-console`
- `camel-catalog-lucene`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-csimple-maven-plugin`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `docs`
- `dummy-component`
</details>
**Skip-tests mode would test 10 modules** (2 direct + 8 downstream), **skip tests for 28** (generated code, meta-modules)
<details><summary>Modules Scalpel would test (10)</summary>
- `camel-jbang-mcp`
- `camel-jbang-plugin-mcp`
- `camel-jbang-plugin-route-parser`
- `camel-jbang-plugin-tui`
- `camel-jbang-plugin-validate`
- `camel-launcher-container`
- `camel-oauth`
- `camel-yaml-dsl-validator`
- `camel-yaml-dsl-validator-maven-plugin`
- `docs`
</details>
<details><summary>Modules with tests skipped (28)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog`
- `camel-catalog-console`
- `camel-catalog-lucene`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-csimple-maven-plugin`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `dummy-component`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
<details><summary>All tested modules (38 modules)</summary>
- Camel :: All Components Sync point
- Camel :: Assembly
- Camel :: Catalog :: CSimple Maven Plugin (deprecated)
- Camel :: Catalog :: Camel Catalog
- Camel :: Catalog :: Camel Report Maven Plugin
- Camel :: Catalog :: Camel Route Parser
- Camel :: Catalog :: Console
- Camel :: Catalog :: Dummy Component
- Camel :: Catalog :: Lucene (deprecated)
- Camel :: Catalog :: Maven
- Camel :: Catalog :: Suggest
- Camel :: Component DSL
- Camel :: Coverage
- Camel :: Docs
- Camel :: Endpoint DSL
- Camel :: Endpoint DSL :: Support
- Camel :: Integration Tests
- Camel :: JBang :: Core
- Camel :: JBang :: Integration tests
- Camel :: JBang :: MCP
- Camel :: JBang :: Main
- Camel :: JBang :: Plugin :: Edit
- Camel :: JBang :: Plugin :: Generate
- Camel :: JBang :: Plugin :: Kubernetes
- Camel :: JBang :: Plugin :: MCP
- Camel :: JBang :: Plugin :: Route Parser
- Camel :: JBang :: Plugin :: TUI
- Camel :: JBang :: Plugin :: Testing
- Camel :: JBang :: Plugin :: Validate
- Camel :: Kamelet Main
- Camel :: Launcher
- Camel :: Launcher :: Container
- Camel :: OAuth
- Camel :: YAML DSL
- Camel :: YAML DSL :: Deserializers
- Camel :: YAML DSL :: Maven Plugins
- Camel :: YAML DSL :: Validator
- Camel :: YAML DSL :: Validator Maven Plugin
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/32512345007)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24411: camel-oauth - stop the route when the processors do not authenticate the request [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25567:
URL: https://github.com/apache/camel/pull/25567#issuecomment-5373595859
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24411: camel-oauth - stop the route when the processors do not authenticate the request [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #25567:
URL: https://github.com/apache/camel/pull/25567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org