You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2008/01/15 01:22:59 UTC
[Bug 5786] New: SpamAssassin 3.2.4 introduces nasty new warnings with Mail::DKIM 0.30
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5786
Summary: SpamAssassin 3.2.4 introduces nasty new warnings with
Mail::DKIM 0.30
Product: Spamassassin
Version: 3.2.4
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Plugins
AssignedTo: dev@spamassassin.apache.org
ReportedBy: nix@esperi.org.uk
CC: Mark.Martinec@ijs.si
These are SA 3.2.4 test results:
t/spf.............................97/106 [27086] warn: Use of uninitialized
value in substitution (s///) at ../blib/lib/Mail/SpamAssassin/Plugin/DKIM.pm
line 338.
[27086] warn: Use of uninitialized value in substitution (s///)
at ../blib/lib/Mail/SpamAssassin/Plugin/DKIM.pm line 338.
[27086] warn: Use of uninitialized value in string ne
at ../blib/lib/Mail/SpamAssassin/Plugin/DKIM.pm line 339.
t/spf.............................99/106 [27090] warn: Use of uninitialized
value in substitution (s///) at ../blib/lib/Mail/SpamAssassin/Plugin/DKIM.pm
line 338.
[27090] warn: Use of uninitialized value in substitution (s///)
at ../blib/lib/Mail/SpamAssassin/Plugin/DKIM.pm line 338.
[27090] warn: Use of uninitialized value in string ne
at ../blib/lib/Mail/SpamAssassin/Plugin/DKIM.pm line 339.
t/spf.............................101/106 [27094] warn: Use of uninitialized
value in substitution (s///) at ../blib/lib/Mail/SpamAssassin/Plugin/DKIM.pm
line 338.
[27094] warn: Use of uninitialized value in substitution (s///)
at ../blib/lib/Mail/SpamAssassin/Plugin/DKIM.pm line 338.
[27094] warn: Use of uninitialized value in string ne
at ../blib/lib/Mail/SpamAssassin/Plugin/DKIM.pm line 339.
t/spf.............................103/106 [27098] warn: Use of uninitialized
value in substitution (s///) at ../blib/lib/Mail/SpamAssassin/Plugin/DKIM.pm
line 338.
[27098] warn: Use of uninitialized value in substitution (s///)
at ../blib/lib/Mail/SpamAssassin/Plugin/DKIM.pm line 338.
[27098] warn: Use of uninitialized value in string ne
at ../blib/lib/Mail/SpamAssassin/Plugin/DKIM.pm line 339.
t/spf.............................ok
Ironically, this bug was introduced by Mark Martinec's Mail::DKIM 0.30-support
patch, which failed to note the effects of this change to Mail::DKIM:
2007-11-14: Jason Long <jl...@messiah.edu>
* lib/Mail/DKIM/Verifier.pm, Signer.pm: update documentation for
message_sender() and message_originator() methods, which are now
guaranteed to return an object
* lib/Mail/DKIM/Common.pm (message_sender, message_originator):
always return a Mail::Address object, even if the relevant headers
were not found
Patch attached.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5786] SpamAssassin 3.2.4 introduces nasty new warnings with Mail::DKIM 0.30
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5786
Mark.Martinec@ijs.si changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4236 is|0 |1
obsolete| |
------- Additional Comments From Mark.Martinec@ijs.si 2008-02-06 16:29 -------
Created an attachment (id=4251)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4251&action=view)
fix for a missing From with DKIM, and a fix to a SPF test mail
combined fix, trivial
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5786] SpamAssassin 3.2.4 introduces nasty new warnings with Mail::DKIM 0.30
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5786
------- Additional Comments From nix@esperi.org.uk 2008-01-14 16:25 -------
Created an attachment (id=4236)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4236&action=view)
Patch to fix breakage with Mail::DKIM 0.30
A trivial patch to cater for the verifier's message_originator method in
Mail::DKIM 0.30 always returning an address which may be empty if there is no
originator, rather than returning undef in that case.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5786] SpamAssassin 3.2.4 introduces nasty new warnings with Mail::DKIM 0.30
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5786
------- Additional Comments From Mark.Martinec@ijs.si 2008-01-28 10:42 -------
> I presume the plans are to apply this to 3.2.5 as well
Sure, can't hurt. Will there be a 3.2.5?
> This leaves a question why the SPF test file t/data/nice/spf3-received-spf
> contains two empty lines in the middle of a header, pushing the last
> couple of header fields (along with a From) into a body. Same in 3.2.4
> and in trunk.
Can I assume this is a bug and the test message should be fixed too?
If so, I'll prepare a (trivial) combined patch to get both changes to 3.2.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5786] SpamAssassin 3.2.4 introduces nasty new warnings with Mail::DKIM 0.30
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5786
------- Additional Comments From nix@esperi.org.uk 2008-01-15 12:29 -------
Isn't it obvious? To find bugs like this one!
Seriously, buggy MTAs, buggy milters, and buggy procmail recipes can all dump
extra linefeeds into headers, and while SA can hardly operate perfectly with
the headers truncated like that, it shouldn't give out uninitialized variable
errors.
(Agreed that this is an unlikely bug, though.)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5786] [review] SpamAssassin 3.2.4 introduces nasty new warnings with Mail::DKIM 0.30
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5786
Mark.Martinec@ijs.si changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From Mark.Martinec@ijs.si 2008-02-07 05:23 -------
$ svn -m 'bug 5786: fix for missing From with DKIM;
remove empty lines from SPF test mail header' ci
Sending lib/Mail/SpamAssassin/Plugin/DKIM.pm
Sending t/data/nice/spf3-received-spf
Committed revision 619403.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5786] [review] SpamAssassin 3.2.4 introduces nasty new warnings with Mail::DKIM 0.30
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5786
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 votes for 3.2.5 |ready to commit
------- Additional Comments From sidney@sidney.com 2008-02-07 04:27 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5786] SpamAssassin 3.2.4 introduces nasty new warnings with Mail::DKIM 0.30
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5786
------- Additional Comments From jm@jmason.org 2008-01-28 12:14 -------
(In reply to comment #6)
> > I presume the plans are to apply this to 3.2.5 as well
>
> Sure, can't hurt. Will there be a 3.2.5?
IMO, yes, we should do one -- bug 5769 at least is ugly enough.
> > This leaves a question why the SPF test file t/data/nice/spf3-received-spf
> > contains two empty lines in the middle of a header, pushing the last
> > couple of header fields (along with a From) into a body. Same in 3.2.4
> > and in trunk.
>
> Can I assume this is a bug and the test message should be fixed too?
> If so, I'll prepare a (trivial) combined patch to get both changes to 3.2.
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5786] [review] SpamAssassin 3.2.4 introduces nasty new warnings with Mail::DKIM 0.30
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5786
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes for 3.2.5 |needs 1 votes for 3.2.5
------- Additional Comments From jm@jmason.org 2008-02-07 01:33 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5786] SpamAssassin 3.2.4 introduces nasty new warnings with Mail::DKIM 0.30
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5786
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.2.5
------- Additional Comments From jm@jmason.org 2008-01-27 03:46 -------
I presume the plans are to apply this to 3.2.5 as well
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5786] SpamAssassin 3.2.4 introduces nasty new warnings with Mail::DKIM 0.30
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5786
guenther@rudersport.de changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |guenther@rudersport.de
------- Additional Comments From guenther@rudersport.de 2008-01-26 21:43 -------
Any plans for 3.2.5? Or why is this bug still open? ;)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5786] SpamAssassin 3.2.4 introduces nasty new warnings with Mail::DKIM 0.30
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5786
------- Additional Comments From spamassassin@dostech.ca 2008-01-28 11:16 -------
> > This leaves a question why the SPF test file t/data/nice/spf3-received-spf
> > contains two empty lines in the middle of a header, pushing the last
> > couple of header fields (along with a From) into a body. Same in 3.2.4
> > and in trunk.
>
> Can I assume this is a bug and the test message should be fixed too?
> If so, I'll prepare a (trivial) combined patch to get both changes to 3.2.
Yes. I have no idea how those empty lines showed up in r487146.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5786] [review] SpamAssassin 3.2.4 introduces nasty new warnings with Mail::DKIM 0.30
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5786
Mark.Martinec@ijs.si changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|SpamAssassin 3.2.4 |[review] SpamAssassin 3.2.4
|introduces nasty new |introduces nasty new
|warnings with Mail::DKIM |warnings with Mail::DKIM
|0.30 |0.30
Status Whiteboard| |needs 2 votes for 3.2.5
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5786] SpamAssassin 3.2.4 introduces nasty new warnings with Mail::DKIM 0.30
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5786
------- Additional Comments From Mark.Martinec@ijs.si 2008-01-15 02:33 -------
> A trivial patch to cater for the verifier's message_originator method in
> Mail::DKIM 0.30 always returning an address which may be empty if there is no
> originator, rather than returning undef in that case.
Thanks, applied to trunk:
svn -m 'DKIM: avoid a "Use of uninitialized value" warning
when a From header field is missing in a message, Bug 5786' ci
Sending lib/Mail/SpamAssassin/Plugin/DKIM.pm
Committed revision 612071.
Messages without a From header field are rarely seen, so the warning
does not occur often in practice.
This leaves a question why the SPF test file t/data/nice/spf3-received-spf
contains two empty lines in the middle of a header, pushing the last
couple of header fields (along with a From) into a body. Same in 3.2.4
and in trunk.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.