[GitHub] xuchuanyin commented on a change in pull request #3063: [CARBONDATA-3242] Move Range_Column into the table level properties

[GitBox <gi...@apache.org>]

xuchuanyin commented on a change in pull request #3063: [CARBONDATA-3242] Move Range_Column into the table level properties
URL: https://github.com/apache/carbondata/pull/3063#discussion_r247352180
 
 

 ##########
 File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestRangeColumnDataLoad.scala
 ##########
 @@ -68,29 +72,40 @@ class TestRangeColumnDataLoad extends QueryTest with BeforeAndAfterEach with Bef
       """
         | CREATE TABLE carbon_range_column2(id INT, name STRING, city STRING, age INT)
         | STORED BY 'org.apache.carbondata.format'
-        | TBLPROPERTIES('SORT_SCOPE'='LOCAL_SORT', 'SORT_COLUMNS'='name, city')
+        | TBLPROPERTIES('SORT_SCOPE'='LOCAL_SORT', 'SORT_COLUMNS'='name, city', 'range_column'='name')
       """.stripMargin)
 
     sql(s"LOAD DATA LOCAL INPATH '$filePath' INTO TABLE carbon_range_column2 " +
-        "OPTIONS('scale_factor'='10', 'range_column'='name')")
+        "OPTIONS('scale_factor'='10')")
 
     assert(getIndexFileCount("carbon_range_column2") === 1)
     checkAnswer(sql("SELECT COUNT(*) FROM carbon_range_column2"), Seq(Row(12)))
     checkAnswer(sql("SELECT * FROM carbon_range_column2"),
       sql("SELECT * FROM carbon_range_column2 ORDER BY name"))
   }
 
-  test("range_column only support single column ") {
+  test("only support single column for create table") {
+    intercept[MalformedCarbonCommandException] {
 
 Review comment:
   For other similar testcases, please check them too

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services