You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Geoffrey Young <ge...@modperlcookbook.org> on 2005/03/30 22:12:09 UTC
outstanding rename items
ok, with the rename merged to trunk there are still a few things outstanding
that I can see.
o CGI.pm - I assumed that 3.08 would be "fixed" wrt the Apache2:: stuff,
but there's really no way to be sure. I'm going to take this on and try to
discuss things with lincoln a bit to see what he wants to do.
o t/response/TestApache2 - I think we can move these back to
t/response/TestApache, since the tests represent testing things about Apache
the server, not Apache2:: the namespace
o docs - and lots of them. we need to port docs/ over to the new
namespace and write a porting doc that outlines the changes folks will need
to do moving forward.
anything else?
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Uwe Voelker <uw...@gmx.de>.
Hello Randy,
> http://svn.apache.org/repos/asf/httpd/apreq/branches/multi-env-unstable/
Ah, thanks. I tried it, but there are still references to Apache2.pm.
For example in glue/perl/Makefile.PL (and in the autogenerated t/TEST).
When I commented them out it compiled fine.
:-)
Bye, Uwe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Sun, 3 Apr 2005, Uwe Voelker wrote:
> Today I tried a fresh mod_perl build out of svn.
>
> > ok, with the rename merged to trunk there are still a
> > few things outstanding that I can see.
>
> mod_perl compiled fine, but libapreq2 had problems:
[ .. ]
For the current svn mod_perl 2 sources there's a separate
branch for libapreq2:
http://svn.apache.org/repos/asf/httpd/apreq/branches/multi-env-unstable/
Note that this requires installation of mod_perl 2 built
from the svn sources. Also note that this branch is marked
as unstable.
--
best regards,
randy kobes
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Uwe Voelker <uw...@gmx.de>.
Today I tried a fresh mod_perl build out of svn.
> ok, with the rename merged to trunk there are still a few things outstanding
> that I can see.
mod_perl compiled fine, but libapreq2 had problems:
build/version_check.pl did not found the modules Apache2 and mod_perl. I
commented out Apache2 and changed mod_perl to mod_perl2 and it worked:
> svn diff build/version_check.pl
Index: build/version_check.pl
===================================================================
--- build/version_check.pl (revision 159966)
+++ build/version_check.pl (working copy)
@@ -32,8 +32,8 @@
sub mp2_version {
eval {
- require Apache2;
- require mod_perl;
+ #require Apache2;
+ require mod_perl2;
$mod_perl::VERSION;
} or do {
require mod_perl;
But later, Apache2 was missing - how can I build libapreq without
Apache2.pm?
And a sidenote to libapreq2: If libtool is not installed there is a
misleading error message:
> ./buildconf
removing stale config files
checking buildconf prereqs
build/version_check.pl failed: no version_string found in ''.
Maybe it should output the name of programm it is testing (libtool in
this case).
Bye,
Uwe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
>stas, perrin had also mentioned the idea that since we were moving from
>Apache::OK to Apache2::OK (again with a virtual namespace) it might make
>more sense to use Apache::Const::OK instead. I guess that's lots of typing,
>but uses always have OK if they want.
I like this idea...
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Stas Bekman wrote:
> Geoffrey Young wrote:
>
>>>> stas, perrin had also mentioned the idea that since we were moving from
>>>> Apache::OK to Apache2::OK (again with a virtual namespace) it might
>>>> make
>>>> more sense to use Apache::Const::OK instead. I guess that's lots of
>>>> typing,
>>>> but uses always have OK if they want.
>>>>
>>>> thoughts?
>>>
>>>
>>>
>>> Sure, go for it.
>>
>>
>>
>> and the same for APR::Const? APR::EBUSY would become APR::Const::EBUSY?
>
>
> Obviously :)
:)
ok, I did both of these. really, I have no idea how the Apache2::Const
rename was working before I changed ConstantTable.pm and ModPerl::Code, but
it was, despite the autogenerated modperl_constants.c having all the wrong
computed class lengths...
so, on that note, if a few other people could take a look at the changes it
would be really appreciated, just to make sure I got it right. here are the
important files:
lib/ModPerl/Code.pm
xs/tables/current/Apache2/ConstantsTable.pm
lib/Apache2/ParseSource.pm
all tests pass for me, but I guess that's no guarantee since they passed on
my first attempt as well...
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>>>stas, perrin had also mentioned the idea that since we were moving from
>>>Apache::OK to Apache2::OK (again with a virtual namespace) it might make
>>>more sense to use Apache::Const::OK instead. I guess that's lots of
>>>typing,
>>>but uses always have OK if they want.
>>>
>>>thoughts?
>>
>>
>>Sure, go for it.
>
>
> and the same for APR::Const? APR::EBUSY would become APR::Const::EBUSY?
Obviously :)
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
>> stas, perrin had also mentioned the idea that since we were moving from
>> Apache::OK to Apache2::OK (again with a virtual namespace) it might make
>> more sense to use Apache::Const::OK instead. I guess that's lots of
>> typing,
>> but uses always have OK if they want.
>>
>> thoughts?
>
>
> Sure, go for it.
and the same for APR::Const? APR::EBUSY would become APR::Const::EBUSY?
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>
> Stas Bekman wrote:
>
>>Geoffrey Young wrote:
>>[...]
>>
>>
>>>>Due to the renaming, methods such as C<Apache-E<gt>server>
>>>>are now called as C<Apache2-E<gt>server>
>>>
>>>
>>>
>>>I think Apache->request/Apache2->request is probably a better example to
>>>use, since it's much more common. or use them both. likewise in the
>>>other
>>>mention below.
>>
>>
>>the only reason Apache->request was kept in the mp2 API is because too
>>many things were using it (like CGI.pm) and I was trying to avoid
>>enforcing changes on users. If you are renaming it anyway, I'd rather
>>see it move into the Apache::RequestRec namespace (same for
>>Apache->server) which should eliminate the top level Apache(2) namespace
>>completely.
>
>
> yeah, I started to wonder about this as I began to port CGI.pm over and
> ended up with lots of calls like
>
> my $r = $ENV{MOD_PERL_API_VERSION} ? Apache2->request : Apache->request;
>
> so maybe abandoning these two makes sense if we're going to rename them
> completely.
>
> on the other hand, I was wonding whether it made sense to continue to
> support Apache2->request _and_ Apache->request. since Apache:: in this
> instance is a virtual class the reasons that forced the change don't really
> apply, so we could just as well keep it. on the other hand, it's all alone
> out there and not comsistent with the rest of the API.
If you change the API completely at least make it consistent.
> stas, perrin had also mentioned the idea that since we were moving from
> Apache::OK to Apache2::OK (again with a virtual namespace) it might make
> more sense to use Apache::Const::OK instead. I guess that's lots of typing,
> but uses always have OK if they want.
>
> thoughts?
Sure, go for it.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Stas Bekman wrote:
> Geoffrey Young wrote:
> [...]
>
>>> Due to the renaming, methods such as C<Apache-E<gt>server>
>>> are now called as C<Apache2-E<gt>server>
>>
>>
>>
>> I think Apache->request/Apache2->request is probably a better example to
>> use, since it's much more common. or use them both. likewise in the
>> other
>> mention below.
>
>
> the only reason Apache->request was kept in the mp2 API is because too
> many things were using it (like CGI.pm) and I was trying to avoid
> enforcing changes on users. If you are renaming it anyway, I'd rather
> see it move into the Apache::RequestRec namespace (same for
> Apache->server) which should eliminate the top level Apache(2) namespace
> completely.
yeah, I started to wonder about this as I began to port CGI.pm over and
ended up with lots of calls like
my $r = $ENV{MOD_PERL_API_VERSION} ? Apache2->request : Apache->request;
so maybe abandoning these two makes sense if we're going to rename them
completely.
on the other hand, I was wonding whether it made sense to continue to
support Apache2->request _and_ Apache->request. since Apache:: in this
instance is a virtual class the reasons that forced the change don't really
apply, so we could just as well keep it. on the other hand, it's all alone
out there and not comsistent with the rest of the API.
stas, perrin had also mentioned the idea that since we were moving from
Apache::OK to Apache2::OK (again with a virtual namespace) it might make
more sense to use Apache::Const::OK instead. I guess that's lots of typing,
but uses always have OK if they want.
thoughts?
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
[...]
>>Due to the renaming, methods such as C<Apache-E<gt>server>
>>are now called as C<Apache2-E<gt>server>
>
>
> I think Apache->request/Apache2->request is probably a better example to
> use, since it's much more common. or use them both. likewise in the other
> mention below.
the only reason Apache->request was kept in the mp2 API is because too
many things were using it (like CGI.pm) and I was trying to avoid
enforcing changes on users. If you are renaming it anyway, I'd rather see
it move into the Apache::RequestRec namespace (same for Apache->server)
which should eliminate the top level Apache(2) namespace completely.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> I think I've changed most of the docs now to use Apache2::*,
> rather than Apache::*; of course, there's likely places I
> missed. Also, in particular, the porting docs, and those
> involving Apache2::compat, should be checked, as there it's
> not a straight s/Apache/Apache2/g replace.
nice work randy!
> Also, I'll have
> to check more thoroughly if any of these changes resulted
> in broken internal links.
yeah, we should probably run some link checker against the whole thing from
time to time, these changes notwithstanding.
>
> I've also started a skeleton (attached) for a document
> trying to describe for users the effects of these changes.
beautiful!
> Due to the renaming, methods such as C<Apache-E<gt>server>
> are now called as C<Apache2-E<gt>server>
I think Apache->request/Apache2->request is probably a better example to
use, since it's much more common. or use them both. likewise in the other
mention below.
other than that it looks great. we should stick it someplace in the docs
then point
http://perl.apache.org/somelinkwellwritelater
from Makefile.PL to it.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Thu, 7 Apr 2005, Geoffrey Young wrote:
> Randy Kobes wrote:
> > On Thu, 7 Apr 2005, Geoffrey Young wrote:
> >
> >>>I've also started a skeleton (attached) for a document
> >>>trying to describe for users the effects of these changes.
> >>
> >>did this ever make it into the docs?
> >
> > No, not yet - what about as
> > modperl-docs/src/docs/2.0/rename.pod
>
> sounds fine to me.
thanks - that's been added now, with updates on the
additional changes to Apache->request, Apache::OK, etc.
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Randy Kobes wrote:
> On Thu, 7 Apr 2005, Geoffrey Young wrote:
>
>
>>>I've also started a skeleton (attached) for a document
>>>trying to describe for users the effects of these changes.
>>
>>did this ever make it into the docs?
>
>
> No, not yet - what about as
> modperl-docs/src/docs/2.0/rename.pod
sounds fine to me.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Thu, 7 Apr 2005, Geoffrey Young wrote:
>
> > I've also started a skeleton (attached) for a document
> > trying to describe for users the effects of these changes.
>
> did this ever make it into the docs?
No, not yet - what about as
modperl-docs/src/docs/2.0/rename.pod
Or is there a better name/location? Once that's decided,
I'll commit it (with some changes added about the recent
changes to Apache2::OK, Apache2->server, etc.).
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> I've also started a skeleton (attached) for a document
> trying to describe for users the effects of these changes.
did this ever make it into the docs?
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Fri, 1 Apr 2005, Geoffrey Young wrote:
>
> > hmm, ok. how about this - we turn off the cron job that updates
> > perl.apache.org so that whatever changes we make during the port aren't
> > shown on the website.
>
> ok, I did this. at least I hope I did :)
>
> so, you should be free to update the docs in svn as you
> find time without fear that they will propagate to the
> website. at least that's the theory :)
>
> we'll see what state we're in on monday and go from there.
I think I've changed most of the docs now to use Apache2::*,
rather than Apache::*; of course, there's likely places I
missed. Also, in particular, the porting docs, and those
involving Apache2::compat, should be checked, as there it's
not a straight s/Apache/Apache2/g replace. Also, I'll have
to check more thoroughly if any of these changes resulted
in broken internal links.
I've also started a skeleton (attached) for a document
trying to describe for users the effects of these changes.
--
best regards,
randy
Re: outstanding rename items
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Fri, 1 Apr 2005, Geoffrey Young wrote:
>
> > hmm, ok. how about this - we turn off the cron job that updates
> > perl.apache.org so that whatever changes we make during the port aren't
> > shown on the website.
>
> ok, I did this. at least I hope I did :)
>
> so, you should be free to update the docs in svn as you find time without
> fear that they will propagate to the website. at least that's the theory :)
>
> we'll see what state we're in on monday and go from there.
>
> --Geoff
OK, thanks - I'll work on this tomorrow, and hopefully get
the bulk of the changes done as far as s/Apache/Apache2/
goes.
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> hmm, ok. how about this - we turn off the cron job that updates
> perl.apache.org so that whatever changes we make during the port aren't
> shown on the website.
ok, I did this. at least I hope I did :)
so, you should be free to update the docs in svn as you find time without
fear that they will propagate to the website. at least that's the theory :)
we'll see what state we're in on monday and go from there.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Randy Kobes wrote:
> On Wed, 30 Mar 2005, Geoffrey Young wrote:
>
>
>>>I could take a stab at beginning to port the docs over to
>>>the new namespace. Should I wait on that, or the sooner
>>>the better? If sooner, I'll try to do much of it in one go
>>>this weekend, so as to leave things in as consistent state
>>>as possible.
>>
>>I'd say sooner rather than later. as it stands now the
>>docs are out of sync with the API.
>
>
> Would it be a consideration to get a release candidate out
> before changing the docs? If we change the docs now, the
> docs at perl.apache.org get changed, which will then reflect
> the svn API, but not the current CPAN release candidate.
> This, furthermore, will put the docs at search.cpan.org out
> of sync with perl.apache.org, since they're based on the
> CPAN version.
hmm, ok. how about this - we turn off the cron job that updates
perl.apache.org so that whatever changes we make during the port aren't
shown on the website. when we're done, we sync the site and roll RC5.
?
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Wed, 30 Mar 2005, Geoffrey Young wrote:
>
> > I could take a stab at beginning to port the docs over to
> > the new namespace. Should I wait on that, or the sooner
> > the better? If sooner, I'll try to do much of it in one go
> > this weekend, so as to leave things in as consistent state
> > as possible.
>
> I'd say sooner rather than later. as it stands now the
> docs are out of sync with the API.
Would it be a consideration to get a release candidate out
before changing the docs? If we change the docs now, the
docs at perl.apache.org get changed, which will then reflect
the svn API, but not the current CPAN release candidate.
This, furthermore, will put the docs at search.cpan.org out
of sync with perl.apache.org, since they're based on the
CPAN version.
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> I could take a stab at beginning to port the docs over to
> the new namespace. Should I wait on that, or the sooner
> the better? If sooner, I'll try to do much of it in one go
> this weekend, so as to leave things in as consistent state
> as possible.
I'd say sooner rather than later. as it stands now the docs are out of sync
with the API.
>
>
>>anything else?
>
>
> At one point there was some discussion about whether
> or not to keep with the current behaviour of refusing
> to install over an old mod_perl-1.99. Is that still the
> plan?
I think joe initially objected but withdrew after I made an alternate case.
but if there are other opinions out there there's no reason we can't still
discuss it. as it stands now, trunk will not install over any version of
mod_perl 2.0 save trunk or greater. this happens to include any cvs install
from the last release until today, but I don't think that's a concern.
mod_perl 1.0 is unaffected by this.
> Just as one small data point in favour of doing
> so - at one point I installed both in the same tree,
> just as a test, and then found that
> perl -MApache2 -MExtUtils::Embed -e "print 1"
> produced an error about a bare word (load) being unquoted.
> This may have been an error on my part in the way I
> installed things, and so is probably fixable, but as was
> raised earlier, it doesn't seem worth the effort to
> support earlier mod_perl-1.99 installs.
I fully agree.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: outstanding rename items
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Wed, 30 Mar 2005, Geoffrey Young wrote:
> ok, with the rename merged to trunk there are still a few things outstanding
> that I can see.
>
> o CGI.pm - I assumed that 3.08 would be "fixed" wrt the Apache2:: stuff,
> but there's really no way to be sure. I'm going to take this on and try to
> discuss things with lincoln a bit to see what he wants to do.
>
> o t/response/TestApache2 - I think we can move these back to
> t/response/TestApache, since the tests represent testing things about Apache
> the server, not Apache2:: the namespace
>
> o docs - and lots of them. we need to port docs/ over to the new
> namespace and write a porting doc that outlines the changes folks will need
> to do moving forward.
I could take a stab at beginning to port the docs over to
the new namespace. Should I wait on that, or the sooner
the better? If sooner, I'll try to do much of it in one go
this weekend, so as to leave things in as consistent state
as possible.
> anything else?
At one point there was some discussion about whether
or not to keep with the current behaviour of refusing
to install over an old mod_perl-1.99. Is that still the
plan? Just as one small data point in favour of doing
so - at one point I installed both in the same tree,
just as a test, and then found that
perl -MApache2 -MExtUtils::Embed -e "print 1"
produced an error about a bare word (load) being unquoted.
This may have been an error on my part in the way I
installed things, and so is probably fixable, but as was
raised earlier, it doesn't seem worth the effort to
support earlier mod_perl-1.99 installs.
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org