You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Robert Scholte (Jira)" <ji...@apache.org> on 2020/03/28 20:56:00 UTC
[jira] [Closed] (MNG-6726) Integration tests should use non empty
MAVEN_OPTS. Jenkinsfile and 'core-it-suite' should accept custom MAVEN_OPTS
from developers and their CLI.
[ https://issues.apache.org/jira/browse/MNG-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte closed MNG-6726.
-------------------------------
Fix Version/s: (was: 3.7.x-candidate)
Assignee: Robert Scholte (was: Tibor Digana)
Resolution: Won't Fix
I'm going to close this as won't fix. The issue has been identified and ITs are stable for a long time, so I don't see the need for this.
> Integration tests should use non empty MAVEN_OPTS. Jenkinsfile and 'core-it-suite' should accept custom MAVEN_OPTS from developers and their CLI.
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MNG-6726
> URL: https://issues.apache.org/jira/browse/MNG-6726
> Project: Maven
> Issue Type: Task
> Components: Integration Tests
> Environment: Jenkins CI, development environment too
> Reporter: Tibor Digana
> Assignee: Robert Scholte
> Priority: Major
>
> Using non-empty {{MAVEN_OPTS}} (dummy prop) to prevent from merging env vars in child integration test with env vars from (caller) parent process.
> The child env var takes the precedence in this fix.
> Merging env vars between parent/child processes is performed in maven-shared-utils:
> see {{Commandline#addSystemEnvironment()}} and see the line
> {{Properties systemEnvVars = CommandLineUtils.getSystemEnvVars()}}.
> With this fix we can freely use the {{MAVEN_OPTS}} within our integration tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)