[GitHub] markusthoemmes commented on a change in pull request #3538: Code clean up in test suites

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3538: Code clean up in test suites
URL: https://github.com/apache/incubator-openwhisk/pull/3538#discussion_r180647015
 
 

 ##########
 File path: tests/src/test/scala/whisk/core/cli/test/WskEntitlementTests.scala
 ##########
 @@ -214,11 +214,11 @@ abstract class WskEntitlementTests extends TestHelpers with WskTestHelpers with
 
       val stdout = wsk.pkg.get(name)(defaultWskProps).stdout
       val annotationString = wsk.parseJsonString(stdout).fields("annotations").toString
-      annotationString should include regex (""""key":"a"""")
-      annotationString should include regex (""""value":"A"""")
-      annotationString should include regex (s""""key":"${WhiskPackage.bindingFieldName}"""")
-      annotationString should not include regex(""""key":"xxx"""")
-      annotationString should include regex (s""""name":"${samplePackage}"""")
+      annotationString should include(""""key":"a"""")
+      annotationString should include(""""value":"A"""")
+      annotationString should include(s""""key":"${WhiskPackage.bindingFieldName}"""")
+      annotationString should not include (""""key":"xxx"""")
+      annotationString should include(s""""name":"${samplePackage}"""")
 
 Review comment:
   If we're touching this anyway: Can we assert on the json itself and not `toString` the whole thing?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services