You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/05/31 15:49:29 UTC
[GitHub] [arrow] pitrou opened a new issue, #35850: [C++] RelWithDebInfo builds disable optimizations
pitrou opened a new issue, #35850:
URL: https://github.com/apache/arrow/issues/35850
### Describe the bug, including details regarding any error messages, version, and platform.
RelWithDebInfo builds add `-O0` to compiler flags, effectively disabling optimizations.
This seems to be caused by https://github.com/apache/arrow/pull/15022
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed issue #35850: [C++] RelWithDebInfo builds disable optimizations
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou closed issue #35850: [C++] RelWithDebInfo builds disable optimizations
URL: https://github.com/apache/arrow/issues/35850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35850: [C++] RelWithDebInfo builds disable optimizations
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35850:
URL: https://github.com/apache/arrow/issues/35850#issuecomment-1570922238
Oh, sorry.
Does this work?
```diff
diff --git a/cpp/cmake_modules/SetupCxxFlags.cmake b/cpp/cmake_modules/SetupCxxFlags.cmake
index 827e0fa4e..2daaabb97 100644
--- a/cpp/cmake_modules/SetupCxxFlags.cmake
+++ b/cpp/cmake_modules/SetupCxxFlags.cmake
@@ -642,8 +642,8 @@ if(NOT MSVC)
string(APPEND CMAKE_CXX_FLAGS_RELEASE "${CXX_RELEASE_FLAGS}")
string(APPEND CMAKE_C_FLAGS_DEBUG "${DEBUG_FLAGS}")
string(APPEND CMAKE_CXX_FLAGS_DEBUG "${DEBUG_FLAGS}")
- string(APPEND CMAKE_C_FLAGS_RELWITHDEBINFO "${C_RELEASE_FLAGS} ${DEBUG_FLAGS}")
- string(APPEND CMAKE_CXX_FLAGS_RELWITHDEBINFO "${CXX_RELEASE_FLAGS} ${DEBUG_FLAGS}")
+ string(APPEND CMAKE_C_FLAGS_RELWITHDEBINFO "${DEBUG_FLAGS} ${C_RELEASE_FLAGS}")
+ string(APPEND CMAKE_CXX_FLAGS_RELWITHDEBINFO "${DEBUG_FLAGS} ${CXX_RELEASE_FLAGS}")
endif()
message(STATUS "Build Type: ${CMAKE_BUILD_TYPE}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on issue #35850: [C++] RelWithDebInfo builds disable optimizations
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #35850:
URL: https://github.com/apache/arrow/issues/35850#issuecomment-1570519095
No, we should fix this bug. `RelWithDebInfo` should enable the exact same optimizations as `Release`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on issue #35850: [C++] RelWithDebInfo builds disable optimizations
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #35850:
URL: https://github.com/apache/arrow/issues/35850#issuecomment-1570492310
@raulcd This could be 12.0.1 material if we can integrate a fix quickly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on issue #35850: [C++] RelWithDebInfo builds disable optimizations
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on issue #35850:
URL: https://github.com/apache/arrow/issues/35850#issuecomment-1570517824
I guess we might force using `Release` on benchmark, though `Release` only uses `O2`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on issue #35850: [C++] RelWithDebInfo builds disable optimizations
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #35850:
URL: https://github.com/apache/arrow/issues/35850#issuecomment-1570491760
@felipecrv Would you like to take a look at this quickly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on issue #35850: [C++] RelWithDebInfo builds disable optimizations
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #35850:
URL: https://github.com/apache/arrow/issues/35850#issuecomment-1570514628
Also cc @mapleFU
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35850: [C++] RelWithDebInfo builds disable optimizations
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35850:
URL: https://github.com/apache/arrow/issues/35850#issuecomment-1570927686
I've opened a pull request for easy to try: #35856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org