You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/12/04 15:16:36 UTC
[GitHub] [incubator-doris] whutpencil opened a new pull request #7301: [Function] Add Function date_trunc() doc and FE test case. (#7298)
whutpencil opened a new pull request #7301:
URL: https://github.com/apache/incubator-doris/pull/7301
## Proposed changes
date_trunc() is a very useful function in Hive, MySQL and Presto. We should add it to Doris. The date_trunc document and some test case is added to this commit, and the implementation code will be supplemented by others.
By the way, in my understanding, the registration of functions is involved, so the order of function implementation is BE to FE. I can complete the development of the FE side, but because my C++ is not very good, I hope someone will supplement the implementation of the BE side, and then I will attach the FE side code.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #7301: [Function] Add Function date_trunc() doc and FE test case
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #7301:
URL: https://github.com/apache/incubator-doris/pull/7301#issuecomment-986045937
Hi @whutpencil , thanks for your contribution.
But you have implement the function on BE side (required) and FE side(Optional), or the query may crash during the execution.
The FE side implementation of a function is just for calculating the function result with all constant parameters.
such as `date_trunc('2010-12-02 19:28:30', 'year');`, but is we call `date_trunc(column1, 'year');`, it has to be
executed on BE side.
But if you wish, you can just pull your FE side implementation, and see if someone can help you to impement the BE side
based on your FE side implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] whutpencil commented on pull request #7301: [Function] Add Function date_trunc() doc and FE test case
Posted by GitBox <gi...@apache.org>.
whutpencil commented on pull request #7301:
URL: https://github.com/apache/incubator-doris/pull/7301#issuecomment-986102468
> Hi @whutpencil , thanks for your contribution. But you have implement the function on BE side (required) and FE side(Optional), or the query may crash during the execution.
>
> The FE side implementation of a function is just for calculating the function result with all constant parameters. such as `date_trunc('2010-12-02 19:28:30', 'year');`, but is we call `date_trunc(column1, 'year');`, it has to be executed on BE side.
>
> But if you wish, you can just pull your FE side implementation, and see if someone can help you to impement the BE side based on your FE side implementation.
Thank you for your explanation. My FE implementation has been attached. This is my first time to submit PR, hoping to make some contributions to the Doris community. The logic of this function is not complex, so I hope someone can implement the BE end as soon as possible.
After then we can remove the word "developing" from the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org