You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/01/02 07:00:14 UTC
[GitHub] [incubator-iotdb] JackieTien97 opened a new pull request #704: Add
log for deadlock
JackieTien97 opened a new pull request #704: Add log for deadlock
URL: https://github.com/apache/incubator-iotdb/pull/704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request
#704: Add log for deadlock
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #704: Add log for deadlock
URL: https://github.com/apache/incubator-iotdb/pull/704#discussion_r362386559
##########
File path: server/src/main/java/org/apache/iotdb/db/query/dataset/NewEngineDataSetWithoutValueFilter.java
##########
@@ -66,7 +68,9 @@ public void run() {
if (batchData.isEmpty()) {
continue;
}
+ logger.info("Reader-" + index + ": start putting batch data into queue");
Review comment:
And `if (logger.isDebugEnable())` is needed if there are too many string concat operations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] JackieTien97 closed pull request #704: Add log
for deadlock
Posted by GitBox <gi...@apache.org>.
JackieTien97 closed pull request #704: Add log for deadlock
URL: https://github.com/apache/incubator-iotdb/pull/704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request
#704: Add log for deadlock
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #704: Add log for deadlock
URL: https://github.com/apache/incubator-iotdb/pull/704#discussion_r362386418
##########
File path: server/src/main/java/org/apache/iotdb/db/query/dataset/NewEngineDataSetWithoutValueFilter.java
##########
@@ -66,7 +68,9 @@ public void run() {
if (batchData.isEmpty()) {
continue;
}
+ logger.info("Reader-" + index + ": start putting batch data into queue");
Review comment:
Hi, if you want to merge the codes into master branch, `logger.info` is too high level...
I suggest you use logger.debug and modify logback.xml to claim the log level of NewEngineDataSetWithoutValueFilter.java as debug. （But do not forget to recover the logback.xml file after the test)
```
<logger level="debug" name="THE CLASS NAME">
<appender-ref ref="stdout"/>
</logger>
```
Or, if you just want to use travis to reproduce the issue, you can manually trigger a request on travis by using the following parameter:
`-Dlogback.configurationFile=/temporary/logback.xml`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request
#704: Add log for deadlock
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #704: Add log for deadlock
URL: https://github.com/apache/incubator-iotdb/pull/704#discussion_r362386418
##########
File path: server/src/main/java/org/apache/iotdb/db/query/dataset/NewEngineDataSetWithoutValueFilter.java
##########
@@ -66,7 +68,9 @@ public void run() {
if (batchData.isEmpty()) {
continue;
}
+ logger.info("Reader-" + index + ": start putting batch data into queue");
Review comment:
Hi, if you want to merge the codes into master branch, `logger.info` is too high level...
I suggest you use logger.debug and modify logback.xml to claim the log level of NewEngineDataSetWithoutValueFilter.java as debug. （But do not forget to recover the logback.xml file after the test)
```
<logger level="debug" name="org.apache.iotdb.db.conf.adapter.IoTDBConfigDynamicAdapter">
<appender-ref ref="stdout"/>
</logger>
```
Or, if you just want to use travis to reproduce the issue, you can manually trigger a request on travis by using the following parameter:
`-Dlogback.configurationFile=/temporary/logback.xml`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services