You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by bv...@apache.org on 2021/01/03 11:24:59 UTC

[camel] branch master updated: adjust Throwable.printStackTrace() method calls

This is an automated email from the ASF dual-hosted git repository.

bvahdat pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/master by this push:
     new 39a29f7  adjust Throwable.printStackTrace() method calls
39a29f7 is described below

commit 39a29f7a0caaa1c527185abe087e2ac523803610
Author: Babak Vahdat <bv...@apache.org>
AuthorDate: Sun Jan 3 12:24:21 2021 +0100

    adjust Throwable.printStackTrace() method calls
---
 .../camel/component/lumberjack/LumberjackMultiThreadTest.java     | 3 ++-
 .../rabbitmq/test/infra/services/QpidEmbeddedService.java         | 3 ++-
 .../java/org/apache/camel/itest/security/GreeterClientTest.java   | 8 +-------
 3 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/components/camel-lumberjack/src/test/java/org/apache/camel/component/lumberjack/LumberjackMultiThreadTest.java b/components/camel-lumberjack/src/test/java/org/apache/camel/component/lumberjack/LumberjackMultiThreadTest.java
index e2305f6..cbdc78b 100644
--- a/components/camel-lumberjack/src/test/java/org/apache/camel/component/lumberjack/LumberjackMultiThreadTest.java
+++ b/components/camel-lumberjack/src/test/java/org/apache/camel/component/lumberjack/LumberjackMultiThreadTest.java
@@ -30,6 +30,7 @@ import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.fail;
 
 public class LumberjackMultiThreadTest extends CamelTestSupport {
 
@@ -92,7 +93,7 @@ public class LumberjackMultiThreadTest extends CamelTestSupport {
             try {
                 this.responses = LumberjackUtil.sendMessages(port, null, Arrays.asList(15, 10));
             } catch (InterruptedException e) {
-                e.printStackTrace();
+                fail(e);
             }
         }
 
diff --git a/components/camel-rabbitmq/src/test/java/org/apache/camel/component/rabbitmq/test/infra/services/QpidEmbeddedService.java b/components/camel-rabbitmq/src/test/java/org/apache/camel/component/rabbitmq/test/infra/services/QpidEmbeddedService.java
index b3896d0..03c0ab6 100644
--- a/components/camel-rabbitmq/src/test/java/org/apache/camel/component/rabbitmq/test/infra/services/QpidEmbeddedService.java
+++ b/components/camel-rabbitmq/src/test/java/org/apache/camel/component/rabbitmq/test/infra/services/QpidEmbeddedService.java
@@ -91,7 +91,8 @@ public class QpidEmbeddedService implements RabbitMQService {
             systemLauncher.startup(createQpidSystemConfig());
             LOG.info("Qpid embedded service running on {}", getAmqpUrl());
         } catch (Exception e) {
-            e.printStackTrace();
+            LOG.error("Initialization failed!", e);
+            throw new IllegalStateException(e.getMessage());
         }
     }
 
diff --git a/tests/camel-itest/src/test/java/org/apache/camel/itest/security/GreeterClientTest.java b/tests/camel-itest/src/test/java/org/apache/camel/itest/security/GreeterClientTest.java
index 99374a6..0ca6315 100644
--- a/tests/camel-itest/src/test/java/org/apache/camel/itest/security/GreeterClientTest.java
+++ b/tests/camel-itest/src/test/java/org/apache/camel/itest/security/GreeterClientTest.java
@@ -44,13 +44,7 @@ import static org.junit.jupiter.api.Assertions.fail;
 public class GreeterClientTest {
     private static final java.net.URL WSDL_LOC;
     static {
-        java.net.URL tmp = null;
-        try {
-            tmp = GreeterClientTest.class.getClassLoader().getResource("wsdl/hello_world.wsdl");
-        } catch (final Exception e) {
-            e.printStackTrace();
-        }
-        WSDL_LOC = tmp;
+        WSDL_LOC = GreeterClientTest.class.getClassLoader().getResource("wsdl/hello_world.wsdl");
     }
     private static final QName SERVICE_QNAME = new QName("http://apache.org/hello_world_soap_http", "SOAPService");