You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Szilard Nemeth (Jira)" <ji...@apache.org> on 2021/07/31 15:29:00 UTC
[jira] [Comment Edited] (YARN-10547) Decouple job parsing logic
from SLSRunner
[ https://issues.apache.org/jira/browse/YARN-10547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390987#comment-17390987 ]
Szilard Nemeth edited comment on YARN-10547 at 7/31/21, 3:28 PM:
-----------------------------------------------------------------
Hi [~gandras],
Thanks for your review comments.
Let me try to answer your questions and address your concerns.
1. Did you mean org.apache.hadoop.yarn.sls.AMDefinition.AmDefinitionBuilder is not a standard builder? It's just an abstact base class for other builders: org.apache.hadoop.yarn.sls.AMDefinitionRumen.Builder, org.apache.hadoop.yarn.sls.AMDefinitionSLS.Builder and org.apache.hadoop.yarn.sls.AMDefinitionSynth.Builder. The reason of this is that these 3 builders are sharing common fields and I wanted to spare them to a common builder base class.
I think these 3 concrete builder classes are standard fluent API based Builders. Do you think they are not?
I hope that this makes sense.
2. Good point, fixed.
3. Good point, fixed all of these.
Uploaded [^YARN-10547.005.patch] to address your concerns. Please check.
was (Author: snemeth):
Hi [~gandras],
Thanks for your review comments.
Let me try to answer your questions and address your concerns.
1. Did you mean org.apache.hadoop.yarn.sls.AMDefinition.AmDefinitionBuilder is not a standard builder? It's just an abstact base class for other builders: org.apache.hadoop.yarn.sls.AMDefinitionRumen.Builder, org.apache.hadoop.yarn.sls.AMDefinitionSLS.Builder and org.apache.hadoop.yarn.sls.AMDefinitionSynth.Builder. The reason of this is that these 3 builders are sharing common fields and I wanted to spare them to a common builder base class.
I think these 3 concrete builder classes are standard fluent API based Builders. Do you think they are not?
I hope that this makes sense.
2. Good point, fixed.
3. Good point, fixed all of these.
> Decouple job parsing logic from SLSRunner
> -----------------------------------------
>
> Key: YARN-10547
> URL: https://issues.apache.org/jira/browse/YARN-10547
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-10547.001.patch, YARN-10547.002.patch, YARN-10547.003.patch, YARN-10547.004.patch, YARN-10547.005.patch
>
>
> SLSRunner has too many responsibilities.
> One of them is to parse the job details from the SLS input formats and launch the AMs and task containers.
> As a first step, the job parser logic could be decoupled from this class.
> There are 3 types of inputs:
> - SLS trace
> - Synth
> - Rumen
> Their job parsing method are:
> - SLS trace: https://github.com/apache/hadoop/blob/005b854f6bad66defafae0abf95dabc6c36ca8b1/hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/SLSRunner.java#L479-L526
> - Synth: https://github.com/apache/hadoop/blob/005b854f6bad66defafae0abf95dabc6c36ca8b1/hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/SLSRunner.java#L722-L790
> - Rumen: https://github.com/apache/hadoop/blob/005b854f6bad66defafae0abf95dabc6c36ca8b1/hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/SLSRunner.java#L651-L716
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org